Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nextflow language server #7480

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

edmundmiller
Copy link

@edmundmiller edmundmiller commented Oct 8, 2024

  • feat: add nextflow-language-server
  • fix(nextflow): Try going in a different direction
  • chore(nextflow): Clean up version
  • fix(nextflow): use vsix instead of zip
  • chore(nextflow): Update to original repo

Describe your changes

Adds the Nextflow language server that's in the VS Code extension.

Let me know if there's a better way of doing this!

Issue ticket number and link

Checklist before requesting a review

  • I have successfully tested installation of the package.
  • I have successfully tested the package after installation.

Screenshots

@williambotman williambotman requested a review from a team October 8, 2024 19:44
@mehalter
Copy link
Contributor

mehalter commented Nov 6, 2024

@edmundmiller I know I closed my PR, but I think it would be a good idea to update this PR to use the language server directly rather than the VS Code extension since the repo has CI/CD setup now

@edmundmiller
Copy link
Author

@mehalter Done! Let me know if you know how to take care of the other steps like lsp-config, or how to get this set up minimally with neovim! I think we should add those instructions to the nextflow/language-server repo, or link out to the docs on it in the respective places.

@mehalter
Copy link
Contributor

mehalter commented Nov 6, 2024

Thanks @edmundmiller I left a few comments for things to fix in the spec here and I commented on the issue you opened on the language server itself with the Neovim installation instructions!

@mehalter
Copy link
Contributor

mehalter commented Nov 7, 2024

This language server has been added to nvim-lspconfig and is awaiting this PR for addition to mason-lspconfig: williamboman/mason-lspconfig.nvim#486

@edmundmiller
Copy link
Author

@mehalter So this PR is blocked until the mason-lspconfig PR gets unblocked?

@mehalter
Copy link
Contributor

No, this PR needs to be merged before mason-lspconfig

1 similar comment
@mehalter
Copy link
Contributor

No, this PR needs to be merged before mason-lspconfig

@edmundmiller
Copy link
Author

Gotcha! Anything we need to do here then? First time contributor here 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants