Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NavigationAdapter 클래스 수정 #209

Merged
merged 19 commits into from
Oct 17, 2024
Merged

fix: NavigationAdapter 클래스 수정 #209

merged 19 commits into from
Oct 17, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Oct 10, 2024 •
edited
Loading

이슈

closed #208

변경 사항

  • 성능/부하 테스트(nGrinder) 환경 생성용 docker-compose 파일을 추가했습니다. (로컬 환경에서 정상 실행 확인)
  • NavigationAdapter 클래스를 수정했습니다.
    • TMapAPI에 잘못된 요청을 보낼 때 Distance.EMPTY 반환 처리
      • 500 반환으로 서비스 내 코스 생성 기능이 이루어지지 않아 거리 정보만 반환하지 않고 정상 실행하는 플로우로 변경
    • Cache Stampede 현상을 방지하기 위한 분산락 처리 로직 추가
      • Redisson의 분산락을 활용했습니다. 캐싱된 데이터가 존재하지 않을 경우 첫번째 요청만 캐싱 업데이트를 위한 데이터베이스 접근을 허용합니다. 그 외 요청은 대기 후 재요청하여 캐싱된 데이터를 활용할 수 있도록 합니다.

스크린샷

부연 설명

  • PR 나누려고 했는데,, 하다보니 커밋/이슈가 섞여서 이번만 1개 PR로 통합해서 올려요ㅠ.ㅠ

체크리스트

  • Lint 적용 여부
  • 빌드 성공 여부
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가
  • PR에 대해 구체적으로 설명이 되어있는가

@thguss

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added fix 버그 해결에 관한 이슈/PR입니다. module-output-web module-output-storage-services labels Oct 10, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@thguss

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@thguss

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@thguss

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@thguss

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@K-Diger
Copy link
Member

K-Diger commented Oct 10, 2024

출격준비

@github-actions GitHub Actions
Copy link

✅ 빌드 성공 ✅
🚀 출격 준비 완료 👨🏻‍🚀

@thguss
Copy link
Member Author

thguss commented Oct 11, 2024

출격준비

@github-actions GitHub Actions
Copy link

✅ 빌드 성공 ✅
🚀 출격 준비 완료 👨🏻‍🚀

KimDoubleB
KimDoubleB approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@KimDoubleB KimDoubleB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 몇 가지 의견 적어봤어요 ㅎㅎ!

...-output-web/tmap/src/main/kotlin/com/piikii/output/web/tmap/adapter/TmapNavigationAdapter.kt Outdated Show resolved Hide resolved
...-output-web/tmap/src/main/kotlin/com/piikii/output/web/tmap/adapter/TmapNavigationAdapter.kt Outdated Show resolved Hide resolved
piikii-output-cache/redis/src/main/kotlin/com/piikii/output/redis/config/RedisConfig.kt Outdated Show resolved Hide resolved
piikii-output-cache/redis/src/main/kotlin/com/piikii/output/redis/config/RedisConfig.kt Show resolved Hide resolved
piikii-output-cache/redis/build.gradle.kts Outdated Show resolved Hide resolved
@thguss
Copy link
Member Author

thguss commented Oct 14, 2024

고생하셨습니다~ 몇 가지 의견 적어봤어요 ㅎㅎ!

@KimDoubleB
너무 좋은 리뷰들 감사해요!! 🤩🤩
우선 코드 작성 부분은 반영해두었고,
락 관련 로직 부분과 설정 부분 관련해서 아카이빙 남겨주신 부분은 좀 더 알아보고 추가적으로 적용해두도록 하겟숨다!! 🚀

KimDoubleB
KimDoubleB approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@KimDoubleB KimDoubleB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했씀니당~

...-output-web/tmap/src/main/kotlin/com/piikii/output/web/tmap/adapter/TmapNavigationAdapter.kt Outdated Show resolved Hide resolved
...-output-web/tmap/src/main/kotlin/com/piikii/output/web/tmap/adapter/TmapNavigationAdapter.kt Outdated Show resolved Hide resolved
@thguss

This comment was marked as outdated.

Sign in to view
1 similar comment
@thguss

This comment was marked as outdated.

Sign in to view
@thguss

This comment was marked as abuse.

Sign in to view
@thguss
Copy link
Member Author

thguss commented Oct 17, 2024

출격준비

@github-actions GitHub Actions
Copy link

✅ 빌드 성공 ✅
🚀 출격 준비 완료 👨🏻‍🚀

@thguss thguss merged commit c95f3cd into develop Oct 17, 2024
1 check passed
@thguss thguss deleted the fix/cache-stampede branch October 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimDoubleB KimDoubleB KimDoubleB approved these changes

@K-Diger K-Diger K-Diger approved these changes

Assignees

@thguss thguss

Labels
fix 버그 해결에 관한 이슈/PR입니다. module-output-storage-services module-output-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Tmap API 호출 취소 시 거리 정보 null로 반환
3 participants
@thguss @K-Diger @KimDoubleB