-
Notifications
You must be signed in to change notification settings - Fork 2
fix: get sandwich loggic AI -> Algorithm #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
da2d1a3
feat: caching sandwich recommendation
toychip 405ff4f
test: temp generate recomendation
toychip 6a6065d
test: test1
toychip f1ccc98
fix: recommend sandwich use AI -> Algorithm
toychip 277c37d
fix: recommend sandwich use AI -> Algorithm
toychip 91945d9
refactor: print -> log
toychip 9b82c59
feat: delete tempapi
toychip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 0 additions & 26 deletions
26
...ekend-clients/client-mcp/src/main/kotlin/noweekend/client/mcp/recommend/model/Sandwich.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...re/core-api/src/main/kotlin/noweekend/core/api/controller/v1/response/SandwichResponse.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package noweekend.core.api.controller.v1.response | ||
|
|
||
| import java.time.LocalDate | ||
|
|
||
| data class SandwichResponse( | ||
| val startDate: LocalDate, | ||
| val endDate: LocalDate, | ||
| val useAnnualLeave: Int, | ||
| val totalVacationDays: Int, | ||
| ) | ||
|
|
||
| data class SandwichApiResponse( | ||
| val responses: List<SandwichResponse>, | ||
| ) |
4 changes: 2 additions & 2 deletions
4
noweekend-core/core-api/src/main/kotlin/noweekend/core/domain/recommend/RecommendService.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| package noweekend.core.domain.recommend | ||
|
|
||
| import noweekend.client.mcp.recommend.model.SandwichApiResponse | ||
| import noweekend.core.api.controller.v1.request.GenerateVacationRequest | ||
| import noweekend.core.api.controller.v1.response.AiGenerateVacationApiResponse | ||
| import noweekend.core.api.controller.v1.response.SandwichApiResponse | ||
| import noweekend.core.api.controller.v1.response.WeatherResponse | ||
| import noweekend.core.domain.tag.TagRecommendations | ||
|
|
||
| interface RecommendService { | ||
| fun getWeatherRecommend(userId: String): WeatherResponse | ||
| fun getTagRecommend(userId: String): TagRecommendations | ||
| fun getTagRecommendOnlyNew(userId: String): TagRecommendations | ||
| fun getSandwich(userId: String): SandwichApiResponse | ||
| fun getSandwich(): SandwichApiResponse | ||
| fun generateVacation(userId: String, request: GenerateVacationRequest): AiGenerateVacationApiResponse | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
noweekend-core/core-domain/src/main/kotlin/noweekend/core/domain/sandwich/Sandwich.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package noweekend.core.domain.sandwich | ||
|
|
||
| import java.time.LocalDate | ||
|
|
||
| data class Sandwich(val startDate: LocalDate, val endDate: LocalDate) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
메서드 시그니처 변경이 적절하지만 문서화 내용과 불일치합니다.
userId 파라미터가 제거된 것은 내부 계산 로직으로의 변경과 일치하지만, 문서화 내용에서 여전히 "유저의 남은 연차"를 언급하고 있어 실제 구현과 일치하지 않습니다.
문서화 내용을 실제 구현에 맞게 수정하세요:
📝 Committable suggestion
🤖 Prompt for AI Agents