Skip to content

Conversation

@mkSpace
Copy link
Collaborator

@mkSpace mkSpace commented Jul 17, 2025

요약(개요)

작업 내용

  • v2로 스케쥴러 생성 구현

집중해서 리뷰해야 하는 부분

기타 전달 사항 및 참고 자료(선택)

Summary by CodeRabbit

  • 신규 기능

    • 일정 생성 및 수정이 가능한 새로운 API 엔드포인트(v2)가 추가되었습니다.
    • 일정 생성 및 수정 시 제목, 시작/종료 시간, 카테고리, 온도, 알림 옵션 등을 입력할 수 있습니다.
  • 문서화

    • 새로운 일정 관련 API(v2)에 대한 Swagger 문서가 추가되어 요청 및 응답 예시, 필드 설명, 오류 코드 안내가 제공됩니다.
  • 버그 수정

    • 일정의 allDay 속성이 기본값 false로 설정되어, 별도 지정 없이도 정상 동작합니다.

@mkSpace mkSpace self-assigned this Jul 17, 2025
@mkSpace mkSpace requested a review from toychip as a code owner July 17, 2025 10:26
@coderabbitai
Copy link

coderabbitai bot commented Jul 17, 2025

Walkthrough

스케줄 관련 API의 V2 버전이 새롭게 도입되었습니다. 새로운 컨트롤러, 요청 DTO, 서비스 메서드, 도메인 팩토리 메서드가 추가되었으며, Swagger 문서화 인터페이스도 포함됩니다. 주요 변경점은 V2 요청/응답 구조와 검증, 그리고 allDay 필드의 기본값 지정입니다.

Changes

파일/경로 요약 변경 내용 요약
.../controller/v2/ScheduleControllerV2.kt, .../controller/v2/docs/ScheduleControllerDocsV2.kt V2 REST 컨트롤러 및 Swagger 문서화 인터페이스 추가. V2 엔드포인트(생성, 수정) 및 API 응답 래핑 구현.
.../controller/v2/request/ScheduleRequest.kt 스케줄 생성/수정용 V2 요청 DTO(ScheduleCreateRequestV2, ScheduleUpdateRequestV2) 및 필드 검증 추가.
.../service/schedule/ScheduleApplicationService.kt 서비스 인터페이스 및 구현에 V2용 스케줄 생성/수정 메서드 추가. 날짜 검증 및 소유자 확인 포함.
.../domain/schedule/Schedule.kt allDay 필드 기본값을 false로 변경, V2용 팩토리 메서드(newScheduleV2) 추가.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ControllerV2
    participant Service
    participant Domain

    Client->>ControllerV2: POST /api/v2/schedule (ScheduleCreateRequestV2)
    ControllerV2->>Service: createScheduleV2(userId, request)
    Service->>Domain: Schedule.newScheduleV2(...)
    Domain-->>Service: Schedule
    Service-->>ControllerV2: ScheduleResponse
    ControllerV2-->>Client: ApiResponse<ScheduleResponse>

    Client->>ControllerV2: PUT /api/v2/schedule/{id} (ScheduleUpdateRequestV2)
    ControllerV2->>Service: updateScheduleV2(userId, id, request)
    Service->>Domain: (조회 및 복사, 검증)
    Domain-->>Service: Schedule
    Service-->>ControllerV2: ScheduleResponse
    ControllerV2-->>Client: ApiResponse<ScheduleResponse>
Loading

Suggested labels

준형


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a55f428 and d83c554.

📒 Files selected for processing (5)
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/controller/v2/ScheduleControllerV2.kt (1 hunks)
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/controller/v2/docs/ScheduleControllerDocsV2.kt (1 hunks)
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/controller/v2/request/ScheduleRequest.kt (1 hunks)
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/service/schedule/ScheduleApplicationService.kt (4 hunks)
  • noweekend-core/core-domain/src/main/kotlin/noweekend/core/domain/schedule/Schedule.kt (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/controller/v2/docs/ScheduleControllerDocsV2.kt
🚧 Files skipped from review as they are similar to previous changes (4)
  • noweekend-core/core-domain/src/main/kotlin/noweekend/core/domain/schedule/Schedule.kt
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/controller/v2/request/ScheduleRequest.kt
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/service/schedule/ScheduleApplicationService.kt
  • noweekend-core/core-api/src/main/kotlin/noweekend/core/api/controller/v2/ScheduleControllerV2.kt
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkSpace mkSpace force-pushed the feature/schedule-create branch from a55f428 to d83c554 Compare July 17, 2025 10:28
@mkSpace mkSpace merged commit c1728f0 into develop Jul 17, 2025
2 checks passed
@mkSpace mkSpace deleted the feature/schedule-create branch July 17, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants