-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Implement real sandwich recommendation #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3b2d250
refactor: move holiday query logic from service to HolidayReader
toychip b6cea92
feat: weekend data
toychip 048372c
test: test1
toychip 827933f
feat: implement sandwich vacation recommendation using AI results
toychip d03ee6f
feat: add mock data response for sandwich API exceptions
toychip 356a3bb
feat: encrypt public API search key using jasypt
toychip 5a3634a
fix: setting mcp-server production url
toychip b7b065a
chore: remove test weekend generation API
toychip 96d0928
chore: return mockdata sandwich
toychip 12d1d59
refactor: ktlintformat
toychip 9ffaa72
refactor: ktlintformat
toychip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
...kend-clients/client-mcp/src/main/kotlin/noweekend/client/mcp/McpNotRespondingException.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package noweekend.client.mcp | ||
|
|
||
| import java.lang.RuntimeException | ||
|
|
||
| class McpNotRespondingException() : RuntimeException() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...nts/client-mcp/src/main/kotlin/noweekend/client/mcp/recommend/model/AiGenerateVacation.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package noweekend.client.mcp.recommend.model | ||
|
|
||
| import java.time.LocalDate | ||
|
|
||
| data class AiGenerateVacationRequest( | ||
| val days: Int, | ||
|
|
||
| val travelStyleOptionLabels: List<String>, | ||
| val chosenTravelStyleLabel: String, | ||
|
|
||
| val activityTypeOptionLabels: List<String>, | ||
| val chosenActivityTypeLabel: String, | ||
|
|
||
| val restPreferenceOptionLabels: List<String>, | ||
| val chosenRestPreferenceLabel: String, | ||
|
|
||
| val leisurePreferenceOptionLabels: List<String>, | ||
| val chosenLeisurePreferenceLabel: String, | ||
|
|
||
| val birthDate: LocalDate, | ||
| val selectedTags: List<String>, | ||
| val unselectedTags: List<String>, | ||
| val upcomingHolidays: List<String>, | ||
| ) | ||
|
|
||
| data class AiGenerateVacationResponse( | ||
| val title: String, | ||
| val content: String, | ||
| ) | ||
toychip marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 5 additions & 2 deletions
7
noweekend-core/core-api/src/main/kotlin/noweekend/core/domain/recommend/RecommendService.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,15 @@ | ||
| package noweekend.core.domain.recommend | ||
|
|
||
| import noweekend.client.mcp.recommend.model.SandwichResponse | ||
| import noweekend.client.mcp.recommend.model.SandwichApiResponse | ||
| import noweekend.core.api.controller.v1.request.GenerateVacationRequest | ||
| import noweekend.core.api.controller.v1.response.AiGenerateVacationApiResponse | ||
| import noweekend.core.api.controller.v1.response.WeatherResponse | ||
| import noweekend.core.domain.tag.TagRecommendations | ||
|
|
||
| interface RecommendService { | ||
| fun getWeatherRecommend(userId: String): WeatherResponse | ||
| fun getTagRecommend(userId: String): TagRecommendations | ||
| fun getTagRecommendOnlyNew(userId: String): TagRecommendations | ||
| fun getSandwich(userId: String): SandwichResponse | ||
| fun getSandwich(userId: String): SandwichApiResponse | ||
toychip marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| fun generateVacation(userId: String, request: GenerateVacationRequest): AiGenerateVacationApiResponse | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.