Exclude pre-releases from "latest tag" selection in install/upgrade (#49

)
marwanhawari · Jan 19, 2025 · 81d6e1f · 81d6e1f
1 parent 79280da
commit 81d6e1f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/cmd/install.go b/cmd/install.go
@@ -82,7 +82,13 @@ func installOne(pkg stew.PackageData, userOS, userArch string, systemInfo stew.S
 		}
 
 		if tag == "" || tag == "latest" {
-			tag = githubProject.Releases[0].TagName
+			// Find first non-prerelease tag
+			for _, release := range githubProject.Releases {
+				if !release.Prerelease {
+					tag = release.TagName
+					break
+				}
+			}
 		}
 
 		tagIndex, tagFound := stew.Contains(releaseTags, tag)

diff --git a/cmd/upgrade.go b/cmd/upgrade.go
@@ -76,8 +76,13 @@ func upgradeOne(binaryName, userOS, userArch string, lockFile stew.LockFile, sys
 		return err
 	}
 
-	// Get the latest tag
+	// Start at the latest tag
 	tagIndex := 0
+	// Find first non-prerelease tag
+	for githubProject.Releases[tagIndex].Prerelease {
+		tagIndex += 1
+	}
+
 	tag := githubProject.Releases[tagIndex].TagName
 
 	if pkg.Tag == tag {

diff --git a/lib/github.go b/lib/github.go
@@ -21,8 +21,9 @@ type GithubAPIResponse []GithubRelease
 
 // GithubRelease contains information about a GitHub release, including the associated assets
 type GithubRelease struct {
-	TagName string        `json:"tag_name"`
-	Assets  []GithubAsset `json:"assets"`
+	TagName    string        `json:"tag_name"`
+	Assets     []GithubAsset `json:"assets"`
+	Prerelease bool          `json:"prerelease"`
 }
 
 // GithubAsset contains information about a specific GitHub asset