Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cursor/rules.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The AI agents should never link to any issue or a pull request
in any GitHub repository in the code reviews!

The AI agents should not review AI agents' config files like CLAUDE.md or AGENTS.md!

5 changes: 5 additions & 0 deletions .gemini/rules.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The AI agents should never link to any issue or a pull request
in any GitHub repository in the code reviews!

The AI agents should not review AI agents' config files like CLAUDE.md or AGENTS.md!

5 changes: 5 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The AI agents should never link to any issue or a pull request
in any GitHub repository in the code reviews!

The AI agents should not review AI agents' config files like CLAUDE.md or AGENTS.md!

5 changes: 5 additions & 0 deletions CLAUDE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The AI agents should never link to any issue or a pull request
in any GitHub repository in the code reviews!

The AI agents should not review AI agents' config files like CLAUDE.md or AGENTS.md!

3 changes: 1 addition & 2 deletions ballista/core/src/client_pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ use crate::client::BallistaClient;
use crate::error::Result;
use crate::extension::BallistaConfigGrpcEndpoint;
use crate::utils::GrpcClientConfig;
use async_trait::async_trait;
use std::fmt::Debug;
use std::ops::{Deref, DerefMut};
use std::sync::Arc;
Expand All @@ -31,7 +30,7 @@ use std::sync::Arc;
// ---------------------------------------------------------------------------

/// Manages a pool of reusable [BallistaClient] connections.
#[async_trait]
#[async_trait::async_trait]
pub trait BallistaClientPool: Send + Sync + Debug {
/// Acquire an idle client for `(host, port, config)`, or create a new one if the
/// pool is empty for that key. The returned [PooledClient] returns itself
Expand Down
3 changes: 1 addition & 2 deletions ballista/core/src/event_loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,13 @@
use std::sync::Arc;
use std::sync::atomic::{AtomicBool, Ordering};

use async_trait::async_trait;
use log::{error, info};
use tokio::sync::mpsc;

use crate::error::{BallistaError, Result};

/// Trait defining actions to be performed in response to events in an event loop.
#[async_trait]
#[async_trait::async_trait]
pub trait EventAction<E>: Send + Sync {
/// Called when the event loop starts.
fn on_start(&self);
Expand Down
3 changes: 1 addition & 2 deletions ballista/core/src/planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ use crate::config::BallistaConfig;
use crate::execution_plans::{DistributedExplainAnalyzeExec, DistributedQueryExec};
use crate::serde::BallistaLogicalExtensionCodec;

use async_trait::async_trait;
use datafusion::arrow::datatypes::Schema;
use datafusion::common::tree_node::{TreeNode, TreeNodeVisitor};
use datafusion::error::DataFusionError;
Expand Down Expand Up @@ -101,7 +100,7 @@ impl<T: 'static + AsLogicalPlan> BallistaQueryPlanner<T> {
}
}

#[async_trait]
#[async_trait::async_trait]
impl<T: 'static + AsLogicalPlan> QueryPlanner for BallistaQueryPlanner<T> {
async fn create_physical_plan(
&self,
Expand Down
3 changes: 1 addition & 2 deletions ballista/executor/src/client_pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
//! A optional background tokio task evicts idle connections that have not been used
//! within the configured `idle_timeout`.

use async_trait::async_trait;
use ballista_core::client::BallistaClient;
use ballista_core::client_pool::{BallistaClientPool, PooledClient};
use ballista_core::error::Result;
Expand Down Expand Up @@ -146,7 +145,7 @@ fn evict(idle: &IdleMap, timeout: Duration) {
});
}

#[async_trait]
#[async_trait::async_trait]
impl BallistaClientPool for DefaultBallistaClientPool {
async fn acquire(
&self,
Expand Down
5 changes: 2 additions & 3 deletions ballista/executor/src/execution_engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
//! query stages in a distributed setting. The execution engine is responsible
//! for creating query stage executors from physical plans.

use async_trait::async_trait;
use ballista_core::client_pool::BallistaClientPool;
use ballista_core::execution_plans::sort_shuffle::SortShuffleWriterExec;
use ballista_core::execution_plans::{ShuffleReaderExec, ShuffleWriterExec};
Expand Down Expand Up @@ -64,7 +63,7 @@ pub trait ExecutionEngine: Sync + Send {
/// and can be executed as one unit with each partition running in parallel.
/// The output of each partition is re-partitioned and written to disk in
/// Arrow IPC format. Subsequent stages read these results via ShuffleReaderExec.
#[async_trait]
#[async_trait::async_trait]
pub trait QueryStageExecutor: Sync + Send + Debug + Display {
/// Executes a single partition of this query stage.
///
Expand Down Expand Up @@ -230,7 +229,7 @@ impl Display for DefaultQueryStageExec {
}
}

#[async_trait]
#[async_trait::async_trait]
impl QueryStageExecutor for DefaultQueryStageExec {
async fn execute_query_stage(
&self,
Expand Down
5 changes: 2 additions & 3 deletions ballista/scheduler/src/cluster/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ use crate::cluster::{
JobStatus, TaskDistributionPolicy, bind_task_bias, bind_task_round_robin,
};
use crate::state::execution_graph::ExecutionGraphBox;
use async_trait::async_trait;
use ballista_core::error::{BallistaError, Result};
use ballista_core::serde::protobuf::{
AvailableTaskSlots, ExecutorHeartbeat, ExecutorStatus, FailedJob, QueuedJob,
Expand Down Expand Up @@ -63,7 +62,7 @@ pub struct InMemoryClusterState {
cluster_event_sender: ClusterEventSender<ClusterStateEvent>,
}

#[async_trait]
#[async_trait::async_trait]
impl ClusterState for InMemoryClusterState {
async fn bind_schedulable_tasks(
&self,
Expand Down Expand Up @@ -320,7 +319,7 @@ impl ExtendedJobStatus {
}
}

#[async_trait]
#[async_trait::async_trait]
impl JobState for InMemoryJobState {
async fn submit_job(
&self,
Expand Down
4 changes: 2 additions & 2 deletions ballista/scheduler/src/cluster/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ pub type ExecutorSlot = (String, u32);
/// Trait for maintaining a globally consistent view of cluster resources.
///
/// Implementations track executor registration, heartbeats, and available task slots.
#[tonic::async_trait]
#[async_trait::async_trait]
pub trait ClusterState: Send + Sync + 'static {
/// Initializes the cluster state backend.
///
Expand Down Expand Up @@ -277,7 +277,7 @@ pub type JobStateEventStream = Pin<Box<dyn Stream<Item = JobStateEvent> + Send>>
/// Trait for persisting state related to executing jobs.
///
/// Implementations handle job lifecycle, execution graphs, and session management.
#[tonic::async_trait]
#[async_trait::async_trait]
pub trait JobState: Send + Sync {
/// Accepts a job into the scheduler's queue.
///
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
use std::sync::Arc;
use std::time::Duration;

use async_trait::async_trait;
use ballista_core::serde::protobuf::{FailedJob, JobStatus};
use log::{error, info, trace, warn};

Expand Down Expand Up @@ -65,7 +64,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> QueryStageSchedul
}
}

#[async_trait]
#[async_trait::async_trait]
impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan>
EventAction<QueryStageSchedulerEvent> for QueryStageScheduler<T, U>
{
Expand Down
5 changes: 2 additions & 3 deletions ballista/scheduler/src/test_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ use std::future::Future;
use std::sync::Arc;
use std::time::Duration;

use async_trait::async_trait;

use crate::config::SchedulerConfig;
use crate::metrics::SchedulerMetricsCollector;
Expand Down Expand Up @@ -80,7 +79,7 @@ const TEST_SCHEDULER_NAME: &str = "localhost:50050";
#[derive(Debug)]
pub struct ExplodingTableProvider;

#[async_trait]
#[async_trait::async_trait]
impl TableProvider for ExplodingTableProvider {
fn as_any(&self) -> &dyn Any {
self
Expand Down Expand Up @@ -346,7 +345,7 @@ impl VirtualExecutor {
#[derive(Default)]
pub struct BlackholeTaskLauncher {}

#[async_trait]
#[async_trait::async_trait]
impl TaskLauncher for BlackholeTaskLauncher {
async fn launch_tasks(
&self,
Expand Down
2 changes: 1 addition & 1 deletion docs/source/user-guide/extensions-example.md
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ transformation is performed using implementing `ExtensionPlanner` trait:
#[derive(Debug, Clone, Default)]
pub struct CustomPlannerExtension {}

#[async_trait]
#[async_trait::async_trait]
impl ExtensionPlanner for CustomPlannerExtension {
async fn plan_extension(
&self,
Expand Down
Loading