Skip to content

1825: feat(tui): Add configuration popup for jobs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-augment wants to merge 4 commits into
base: main
Choose a base branch
from
Open

1825: feat(tui): Add configuration popup for jobs #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b4532b
feat(tui): Add configuration popup for jobs
jiengup Jun 7, 2026
bba8322
fix manual implementation of .is_multiple_of
jiengup Jun 7, 2026
b474360
remove unused import
jiengup Jun 7, 2026
0dad7d2
Add CLAUDE.md & AGENTS.md
martin-g Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cursor/rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The AI agents should never link to any issue or a pull request
in any GitHub repository in the code reviews!

The AI agents should not review AI agents' config files like CLAUDE.md or AGENTS.md!

5 changes: 5 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The AI agents should never link to any issue or a pull request
in any GitHub repository in the code reviews!

The AI agents should not review AI agents' config files like CLAUDE.md or AGENTS.md!

5 changes: 5 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The AI agents should never link to any issue or a pull request
in any GitHub repository in the code reviews!

The AI agents should not review AI agents' config files like CLAUDE.md or AGENTS.md!

137 changes: 132 additions & 5 deletions ballista-cli/src/tui/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ use crate::tui::{
ExecutorDetailsPopup, ExecutorsData, SortColumn as ExecutorsSortColumn,
},
jobs::{
CancelJobResult, JobDetails, JobPlansPopup, JobsData, PlanTab,
SortColumn as JobsSortColumn,
CancelJobResult, JobConfigPopup, JobDetails, JobPlansPopup, JobsData,
PlanTab, SortColumn as JobsSortColumn,
stages::{JobStagesPopup, StagesGraph},
},
metrics::MetricsData,
Expand All @@ -51,8 +51,9 @@ use tokio::sync::mpsc::Sender;
use crate::tui::http_client::HttpClient;
#[cfg(not(feature = "web"))]
use crate::tui::ui::{
load_executor_details_popup, load_executors_data, load_job_details, load_job_dot,
load_job_stages_popup, load_jobs_data, load_metrics_data,
load_executor_details_popup, load_executors_data, load_job_config_popup,
load_job_details, load_job_dot, load_job_stages_popup, load_jobs_data,
load_metrics_data,
};

const INVALID_DATE: &str = "Invalid date";
Expand Down Expand Up @@ -93,6 +94,7 @@ pub(crate) struct App {
pub show_scheduler_info: bool,
pub job_dot_popup: Option<StagesGraph>,
pub job_plan_popup: Option<JobPlansPopup>,
pub job_config_popup: Option<JobConfigPopup>,
pub job_stages_popup: Option<JobStagesPopup>,
pub executor_details_popup: Option<ExecutorDetailsPopup>,

Expand All @@ -113,6 +115,7 @@ impl App {
job_details: None,
job_dot_popup: None,
job_plan_popup: None,
job_config_popup: None,
job_stages_popup: None,
executor_details_popup: None,
executors_data: ExecutorsData::new(),
Expand Down Expand Up @@ -142,6 +145,14 @@ impl App {
self.input_mode == InputMode::Edit
}

pub fn is_main_search_edit_mode(&self) -> bool {
self.is_edit_mode() && self.job_config_popup.is_none()
}

pub fn is_job_config_search_edit_mode(&self) -> bool {
self.is_edit_mode() && self.job_config_popup.is_some()
}

#[cfg(not(feature = "web"))]
pub fn should_quit(&self) -> bool {
self.should_quit
Expand Down Expand Up @@ -190,6 +201,23 @@ impl App {
pub async fn on_key(&mut self, key: KeyEvent) -> TuiResult<()> {
// Edit mode takes priority over everything
if self.is_edit_mode() {
if let Some(popup) = &mut self.job_config_popup {

@cursor cursor Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale config after jobs refresh

Medium Severity

With the job config popup open, periodic jobs reload can change which job is selected at the same table index while the popup still shows the earlier job’s config. on_tick refreshes job_details for the new selection but never clears or updates job_config_popup, so config and selection can diverge.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0dad7d2. Configure here.

@martin-augment martin-augment Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value:useful; category:bug; feedback: The Bugbot AI reviewer is correct! The tick event handler should check whether the job_config_popup is still valid for the currently selected job and invalidate it if there are not in sync. The data is loaded asynchronously and this may lead to processing late async response for job that is no more the currently selected one.

match key.code {
KeyCode::Esc => {
popup.clear_search();
self.input_mode = InputMode::View;
}
KeyCode::Backspace => {
popup.pop_search_char();
}
KeyCode::Char(c) => {
popup.push_search_char(c);
}
_ => {}
}
return Ok(());
}

match key.code {
KeyCode::Esc => {
self.search_term.clear();
Expand Down Expand Up @@ -287,6 +315,17 @@ impl App {
return Ok(());
}

if let Some(ref mut config_popup) = self.job_config_popup {
match key.code {
KeyCode::Up => config_popup.scroll_up(),
KeyCode::Down => config_popup.scroll_down(),
KeyCode::Char('/') => self.input_mode = InputMode::Edit,
KeyCode::Esc => self.job_config_popup = None,
_ => {}
}
return Ok(());
}

if let Some(ref mut executor_popup) = self.executor_details_popup {
match key.code {
KeyCode::Up => executor_popup.scroll_up(),
Expand Down Expand Up @@ -327,6 +366,9 @@ impl App {
KeyCode::Char('p') if self.is_jobs_view() => {
self.open_job_plan_popup();
}
KeyCode::Char('C') if self.is_jobs_view() => {
self.load_job_config_popup_data().await;
}
KeyCode::Char('e') if self.is_scheduler_up() => {
self.current_view = Views::Executors;
self.load_executors_data().await;
Expand Down Expand Up @@ -465,6 +507,16 @@ impl App {
}
}

#[cfg(not(feature = "web"))]
async fn load_job_config_popup_data(&self) {
if let Some(job) = self.jobs_data.selected_job(&self.search_term) {
let job_id = job.job_id.clone();
if let Err(e) = load_job_config_popup(self, &job_id).await {
tracing::error!("Failed to load job config popup for '{job_id}': {e:?}");
}
}
}

#[cfg(not(feature = "web"))]
async fn load_executor_details_popup_data(&self) {
if let Some(executor) = self.executors_data.selected_executor()
Expand Down Expand Up @@ -623,6 +675,10 @@ impl App {
.is_some_and(|popup| popup.is_plan_view())
}

pub fn is_job_config_popup_open(&self) -> bool {
self.job_config_popup.is_some()
}

fn open_job_plan_popup(&mut self) {
if self.is_selected_job_completed_or_running()
&& let Some(details) = &self.job_details
Expand Down Expand Up @@ -791,6 +847,9 @@ impl App {
UiData::JobDetails(details) => {
self.job_details = Some(details);
}
UiData::JobConfig(popup) => {
self.job_config_popup = Some(popup);
}
UiData::JobStagesGraph(graph) => {
self.job_dot_popup = Some(graph);
}
Expand All @@ -811,6 +870,19 @@ impl App {
#[cfg(feature = "web")]
pub fn on_key_sync(&mut self, key: &KeyEvent) -> Option<WebKeyAsyncAction> {
if self.is_edit_mode() {
if let Some(popup) = &mut self.job_config_popup {
match key.code {
KeyCode::Esc => {
popup.clear_search();
self.input_mode = InputMode::View;
}
KeyCode::Backspace => popup.pop_search_char(),
KeyCode::Char(c) => popup.push_search_char(c),
_ => {}
}
return None;
}

match key.code {
KeyCode::Esc => {
self.search_term.clear();
Expand Down Expand Up @@ -893,6 +965,17 @@ impl App {
return None;
}

if let Some(ref mut config_popup) = self.job_config_popup {
match key.code {
KeyCode::Up => config_popup.scroll_up(),
KeyCode::Down => config_popup.scroll_down(),
KeyCode::Char('/') => self.input_mode = InputMode::Edit,
KeyCode::Esc => self.job_config_popup = None,
_ => {}
}
return None;
}

if let Some(ref mut executor_popup) = self.executor_details_popup {
match key.code {
KeyCode::Up => executor_popup.scroll_up(),
Expand Down Expand Up @@ -948,6 +1031,13 @@ impl App {
self.open_job_plan_popup();
None
}
KeyCode::Char('C') if self.is_jobs_view() => {
let job_id = self
.jobs_data
.selected_job(&self.search_term)
.map(|j| j.job_id.clone());
job_id.map(WebKeyAsyncAction::LoadJobConfig)
}
KeyCode::Char('e') if self.is_scheduler_up() => {
self.current_view = Views::Executors;
Some(WebKeyAsyncAction::ReloadView)
Expand Down Expand Up @@ -1081,6 +1171,7 @@ pub enum WebKeyAsyncAction {
LoadJobStages(String),
LoadExecutorDetails(String),
LoadJobDot(String),
LoadJobConfig(String),
CancelJob(String),
UpdateJobDetails(Option<String>),
ReloadView,
Expand All @@ -1095,8 +1186,8 @@ mod tests {
use crate::tui::domain::{
SchedulerState, SortOrder,
executors::{Executor, ExecutorDetailsPopup, OsInfo, Specification},
jobs::Job,
jobs::stages::{JobStagesPopup, JobStagesResponse},
jobs::{Job, JobConfigEntry, JobConfigPopup},
};
use crate::tui::infrastructure::Settings;

Expand Down Expand Up @@ -1203,6 +1294,22 @@ mod tests {
}
}

fn make_job_config_popup() -> JobConfigPopup {
JobConfigPopup::new(
"j1".to_string(),
vec![
JobConfigEntry {
key: "ballista.job.name".to_string(),
value: "Remote SQL Example".to_string(),
},
JobConfigEntry {
key: "datafusion.execution.batch_size".to_string(),
value: "8192".to_string(),
},
],
)
}

#[test]
fn open_job_plan_popup_opens_for_running_job_with_details() {
let mut app = make_app();
Expand Down Expand Up @@ -1428,6 +1535,26 @@ mod tests {
assert!(app.is_executor_details_popup_open());
}

#[test]
fn is_job_config_popup_open_false_when_none() {
let app = make_app();
assert!(!app.is_job_config_popup_open());
}

#[test]
fn is_job_config_popup_open_true_when_some() {
let mut app = make_app();
app.job_config_popup = Some(make_job_config_popup());
assert!(app.is_job_config_popup_open());
}

#[test]
fn apply_ui_data_sets_job_config_popup() {
let mut app = make_app();
app.apply_ui_data(crate::tui::event::UiData::JobConfig(make_job_config_popup()));
assert!(app.job_config_popup.is_some());
}

// --- format_size tests ---

#[test]
Expand Down
Loading
Loading