Skip to content

Commit

Permalink
monitoring: graduate alertingrules and alertrelabelconfigs to v1
Browse files Browse the repository at this point in the history
Additionally this adds validations and test cases for these vaildations.

Issues: https://issues.redhat.com/browse/MON-2849

Signed-off-by: Jan Fajerski <[email protected]>
  • Loading branch information
jan--f committed Mar 31, 2023
1 parent b6792a7 commit d778f58
Show file tree
Hide file tree
Showing 15 changed files with 2,205 additions and 2 deletions.
5 changes: 5 additions & 0 deletions monitoring/.codegen.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
schemapatch:
requiredFeatureSets:
- ""
- "Default"
- "TechPreviewNoUpgrade"
swaggerdocs:
disabled: false
commentPolicy: Enforce
128 changes: 128 additions & 0 deletions monitoring/v1/0000_50_monitoring_01_alertingrules.crd.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
api-approved.openshift.io: https://github.com/openshift/api/pull/1406
description: OpenShift Monitoring alerting rules
name: alertingrules.monitoring.openshift.io
spec:
group: monitoring.openshift.io
names:
kind: AlertingRule
listKind: AlertingRuleList
plural: alertingrules
singular: alertingrule
scope: Namespaced
versions:
- name: v1
schema:
openAPIV3Schema:
description: "AlertingRule represents a set of user-defined Prometheus rule groups containing alerting rules. This resource is the supported method for cluster admins to create alerts based on metrics recorded by the platform monitoring stack in OpenShift, i.e. the Prometheus instance deployed to the openshift-monitoring namespace. You might use this to create custom alerting rules not shipped with OpenShift based on metrics from components such as the node_exporter, which provides machine-level metrics such as CPU usage, or kube-state-metrics, which provides metrics on Kubernetes usage. \n The API is mostly compatible with the upstream PrometheusRule type from the prometheus-operator. The primary difference being that recording rules are not allowed here -- only alerting rules. For each AlertingRule resource created, a corresponding PrometheusRule will be created in the openshift-monitoring namespace. OpenShift requires admins to use the AlertingRule resource rather than the upstream type in order to allow better OpenShift specific defaulting and validation, while not modifying the upstream APIs directly. \n You can find upstream API documentation for PrometheusRule resources here: \n https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md \n Compatibility level 1: Stable within a major release for a minimum of 12 months or 3 minor releases (whichever is longer)."
type: object
required:
- spec
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
type: string
kind:
description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
type: string
metadata:
type: object
spec:
description: spec describes the desired state of this AlertingRule object.
type: object
required:
- groups
properties:
groups:
description: "groups is a list of grouped alerting rules. Rule groups are the unit at which Prometheus parallelizes rule processing. All rules in a single group share a configured evaluation interval. All rules in the group will be processed together on this interval, sequentially, and all rules will be processed. \n It's common to group related alerting rules into a single AlertingRule resources, and within that resource, closely related alerts, or simply alerts with the same interval, into individual groups. You are also free to create AlertingRule resources with only a single rule group, but be aware that this can have a performance impact on Prometheus if the group is extremely large or has very complex query expressions to evaluate. Spreading very complex rules across multiple groups to allow them to be processed in parallel is also a common use-case."
type: array
minItems: 1
items:
description: RuleGroup is a list of sequentially evaluated alerting rules.
type: object
required:
- name
- rules
properties:
interval:
description: 'interval is how often rules in the group are evaluated. If not specified, it defaults to the global.evaluation_interval configured in Prometheus, which itself defaults to 30 seconds. You can check if this value has been modified from the default on your cluster by inspecting the platform Prometheus configuration: The relevant field in that resource is: spec.evaluationInterval'
type: string
maxLength: 2048
pattern: ^(0|(([0-9]+)y)?(([0-9]+)w)?(([0-9]+)d)?(([0-9]+)h)?(([0-9]+)m)?(([0-9]+)s)?(([0-9]+)ms)?)$
name:
description: name is the name of the group.
type: string
maxLength: 2048
minLength: 1
rules:
description: rules is a list of sequentially evaluated alerting rules. Prometheus may process rule groups in parallel, but rules within a single group are always processed sequentially, and all rules are processed.
type: array
minItems: 1
items:
description: 'Rule describes an alerting rule. See Prometheus documentation: - https://www.prometheus.io/docs/prometheus/latest/configuration/alerting_rules'
type: object
required:
- alert
- expr
properties:
alert:
description: alert is the name of the alert. Must be a valid label value, i.e. may contain any Unicode character.
type: string
maxLength: 2048
minLength: 1
annotations:
description: annotations to add to each alert. These are values that can be used to store longer additional information that you won't query on, such as alert descriptions or runbook links.
type: object
additionalProperties:
type: string
expr:
description: 'expr is the PromQL expression to evaluate. Every evaluation cycle this is evaluated at the current time, and all resultant time series become pending or firing alerts. This is most often a string representing a PromQL expression, e.g.: mapi_current_pending_csr > mapi_max_pending_csr In rare cases this could be a simple integer, e.g. a simple "1" if the intent is to create an alert that is always firing. This is sometimes used to create an always-firing "Watchdog" alert in order to ensure the alerting pipeline is functional.'
anyOf:
- type: integer
- type: string
x-kubernetes-int-or-string: true
for:
description: for is the time period after which alerts are considered firing after first returning results. Alerts which have not yet fired for long enough are considered pending.
type: string
maxLength: 2048
pattern: ^(0|(([0-9]+)y)?(([0-9]+)w)?(([0-9]+)d)?(([0-9]+)h)?(([0-9]+)m)?(([0-9]+)s)?(([0-9]+)ms)?)$
labels:
description: 'labels to add or overwrite for each alert. The results of the PromQL expression for the alert will result in an existing set of labels for the alert, after evaluating the expression, for any label specified here with the same name as a label in that set, the label here wins and overwrites the previous value. These should typically be short identifying values that may be useful to query against. A common example is the alert severity, where one sets `severity: warning` under the `labels` key:'
type: object
additionalProperties:
type: string
x-kubernetes-list-map-keys:
- name
x-kubernetes-list-type: map
status:
description: status describes the current state of this AlertOverrides object.
type: object
properties:
observedGeneration:
description: observedGeneration is the last generation change you've dealt with.
type: integer
format: int64
prometheusRule:
description: prometheusRule is the generated PrometheusRule for this AlertingRule. Each AlertingRule instance results in a generated PrometheusRule object in the same namespace, which is always the openshift-monitoring namespace.
type: object
required:
- name
properties:
name:
description: name of the referenced PrometheusRule.
type: string
maxLength: 2048
minLength: 1
served: true
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Loading

0 comments on commit d778f58

Please sign in to comment.