Skip to content

fix(ui): keep green tool bullets away from the thinking indicator - #320

Merged
martian56 merged 1 commit into
mainfrom
thinking-line-isolation
Jul 24, 2026
Merged

fix(ui): keep green tool bullets away from the thinking indicator#320
martian56 merged 1 commit into
mainfrom
thinking-line-isolation

Conversation

@martian56

@martian56 martian56 commented Jul 24, 2026

Copy link
Copy Markdown
Owner

The pulsing indicator shared its column with the transcript's green tool bullets on the adjacent row, reading as the animation flashing green during tool-heavy turns. A permanent blank spacer row now separates the transcript from the thinking cluster, and the indicator is indented past the bullet column. Local: 444 tests, evals 6/6, fmt clean.

Generated by Rook

Summary by CodeRabbit

  • Bug Fixes
    • Improved chat layout spacing by adding a consistent blank line between the transcript and activity indicators.
    • Corrected the vertical positioning of the input box, todo strip, thinking indicator, and status message.
    • Adjusted the approval message indentation to prevent overlap with tool activity bullets.

The pulsing glyph shared its column with the transcript's tool bullets
(green in every theme) on the row directly above, so during tool-heavy
turns the corner read as the animation flashing green. A permanent blank
spacer row now separates the transcript from the thinking cluster, and the
indicator is indented past the bullet column, so nothing green ever sits
in or beside it.

Co-Authored-By: Rook <308697149+rook-agent-code@users.noreply.github.com>
@martian56 martian56 self-assigned this Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a442568-988c-4846-bd84-14145637a8bf

📥 Commits

Reviewing files that changed from the base of the PR and between f9be306 and 624ac00.

📒 Files selected for processing (1)
  • src/app/view.rv

📝 Walkthrough

Walkthrough

chat_view now includes a permanent blank spacer between the transcript and thinking/todo area. Input, todo, thinking, and status regions are reindexed, and awaiting-approval text is indented horizontally.

Changes

Chat view layout

Layer / File(s) Summary
Reindex layout and approval rendering
src/app/view.rv
Adds a fixed one-row spacer, shifts the input, todo strip, thinking line, and status bar to later layout rows, and indents awaiting-approval text to avoid overlap with tool bullets.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the UI change: separating green tool bullets from the thinking indicator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thinking-line-isolation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martian56
martian56 merged commit 43e2d5b into main Jul 24, 2026
4 checks passed
@martian56
martian56 deleted the thinking-line-isolation branch July 24, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant