Skip to content

feat(rvpm): package directory assets recursively - #882

Merged
martian56 merged 1 commit into
mainfrom
agent/dist-directory-assets
Jul 14, 2026
Merged

martian56 merged 1 commit into
mainfrom
agent/dist-directory-assets

Conversation

@martian56

Copy link
Copy Markdown
Owner

Summary

  • allow [[dist.assets]] sources to name directories
  • recursively preserve their files, nesting, and empty directories beneath dest
  • document directory asset semantics for every dist backend

Implementation

All package formats already consume the shared staging tree. Directory traversal is implemented there, so tar, zip, deb, rpm, MSI, and Inno receive identical layouts while existing file assets retain their current behavior.

Validation

  • cargo fmt --check
  • cargo clippy --workspace --all-targets
  • cargo test --workspace

Fixes #871

@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@martian56, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a07a8bc7-8aac-4264-96a4-f76ebc00dedb

📥 Commits

Reviewing files that changed from the base of the PR and between c665594 and e272be5.

📒 Files selected for processing (3)
  • docs/v2/specs/rvpm-dist.md
  • src/manifest/mod.rs
  • src/ops/dist.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/dist-directory-assets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martian56
martian56 marked this pull request as ready for review July 14, 2026 07:23
@martian56
martian56 merged commit 3758087 into main Jul 14, 2026
6 checks passed
@martian56
martian56 deleted the agent/dist-directory-assets branch July 14, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rvpm dist: allow a directory as an asset source

1 participant