Remove redundant commas of tail null values#180
Merged
marshallward merged 1 commit intomainfrom Oct 7, 2025
Merged
Conversation
Certain compilers require null value assignments to end with commas. The `Namelist` writer contains a special rule to append this comma. If `end_comma` is enabled, which always finalizes values with commas, then this would append a second comma, which would transform the record into two null values. This patch prevents the redundant comma if end_commas are enabled. Thanks to Paul Leopardi (@penguian) for reporting.
marshallward
force-pushed
the
no_extra_end_comma
branch
from
fd090d5 to
87f8e4f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 97.20% 97.21%
=======================================
Files 9 9
Lines 2147 2152 +5
Branches 358 358
=======================================
+ Hits 2087 2092 +5
Misses 35 35
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marshallward
changed the title
marshallward
force-pushed
the
no_extra_end_comma
branch
from
87f8e4f to
aba6aa6
Compare
Owner
Author
|
No update from @penguian but I assume this is working correctly. |
|
@marshallward See conda-forge/f90nml-feedstock#25 which has been awaiting review since 8 October. |
|
f90nml v1.5 incorporating #180 is now available from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain compilers require null value assignments to end with commas. The
Namelistwriter contains a special rule to append this comma.If
end_commais enabled, which always finalizes values with commas, then this would append a second comma, which would transform the record into two null values.This patch prevents the redundant comma if end_commas are enabled.
Thanks to Paul Leopardi (@penguian) for reporting.