TST: fixup CI, drop EOL Python versions#176
Closed
neutrinoceros wants to merge 3 commits intomarshallward:mainfrom
Closed
TST: fixup CI, drop EOL Python versions#176neutrinoceros wants to merge 3 commits intomarshallward:mainfrom
neutrinoceros wants to merge 3 commits intomarshallward:mainfrom
Conversation
Contributor
Author
|
I would also suggest adding the |
Owner
|
Thanks for reporting this. I really bungled the testing here, and should have known better than to use The intention was to do one last release with Python 2 compatibility, then do a major release and drop it entirely. I guess that plan is not exactly an option anymore. I'd like to think on this a little before moving ahead. But as it stands, your PR is entirely correct to drop support (and, of course, fix the testing). |
Contributor
Author
|
No rush on my end ! |
Owner
|
Effectively resolved by #177 although we will come back to the eventual removal of Py2.7 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address 3 problems I encountered with CI:
|operator to join dictionaries, only supported since 3.9)Since actually testing on older Pythons is actually becoming very hard these days, I propose simply dropping them.