Skip to content

TST: fixup CI, drop EOL Python versions#176

Closed
neutrinoceros wants to merge 3 commits intomarshallward:mainfrom
neutrinoceros:tst/fixup-ci
Closed

TST: fixup CI, drop EOL Python versions#176
neutrinoceros wants to merge 3 commits intomarshallward:mainfrom
neutrinoceros:tst/fixup-ci

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented Jul 21, 2025

address 3 problems I encountered with CI:

  • parametrization on Python version didn't work: all jobs were effectively running Python 3.12.3
  • selected ubuntu images are not available any more
  • despite support being claimed for Python 2.7 and 3.5-3.8 (which are all end-of-life), Python 3.9 was effectively required at least since 18cda8f (which used the | operator to join dictionaries, only supported since 3.9)

Since actually testing on older Pythons is actually becoming very hard these days, I propose simply dropping them.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

I would also suggest adding the pull_request trigger on CI, so this could be properly validated

@neutrinoceros neutrinoceros marked this pull request as ready for review July 21, 2025 10:13
@marshallward
Copy link
Copy Markdown
Owner

Thanks for reporting this. I really bungled the testing here, and should have known better than to use d1 | d2 in supposedly Py2 compatible code. (I even had a |= operator in there!).

The intention was to do one last release with Python 2 compatibility, then do a major release and drop it entirely. I guess that plan is not exactly an option anymore.

I'd like to think on this a little before moving ahead. But as it stands, your PR is entirely correct to drop support (and, of course, fix the testing).

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

No rush on my end !

@marshallward
Copy link
Copy Markdown
Owner

Effectively resolved by #177 although we will come back to the eventual removal of Py2.7 support.

@neutrinoceros neutrinoceros deleted the tst/fixup-ci branch July 30, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants