Skip to content

Revert Credit Manager types #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Revert Credit Manager types #43

merged 1 commit into from
Oct 21, 2025
+23 −21

Conversation

Subham2804
Copy link
Contributor

@Subham2804 Subham2804 commented Oct 15, 2025 •
edited
Loading

  1. Remove governance addr from config query in CM to avoid vault query issues
  2. Add check for min voting power must be 0 for lowest tier

Subham2804
Subham2804 commented Oct 15, 2025
View reviewed changes
contracts/credit-manager/src/error.rs
#[error("Duplicate voting power thresholds")]
DuplicateVotingPowerThresholds,

#[error("Lowest tier must have min_voting_power equal to 0")]
Copy link
Contributor Author

@Subham2804 Subham2804 Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowest tier must have 0 min voting power

@Subham2804 Subham2804 requested a review from markonmars October 16, 2025 02:48
@markonmars markonmars changed the title add credit manager config and staking tier fix Revert Credit Manager types Oct 21, 2025
@markonmars markonmars merged commit 51df4e3 into master Oct 21, 2025
3 checks passed
@markonmars markonmars deleted the v2.4.0_cm_fix branch October 21, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markonmars markonmars markonmars approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Subham2804 @markonmars