Skip to content

change sox() returned type and success value #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change sox() returned type and success value #166

wants to merge 1 commit into from

Conversation

@mikeziminio
Copy link

changed docstring for sox() returned type and success value

@lostanlen
Copy link
Member

Thanks! please add a unit test

@mikeziminio
Copy link
Author

Thanks! please add a unit test

Vincent, thanks for the quick response!
I only changed the docstring, so I have no idea what tests can be added. Please advise me.

@lostanlen
Copy link
Member

test that indeed sox returns an integer and that this integer is zero

@mikeziminio
Copy link
Author

test that indeed sox returns an integer and that this integer is zero

ok, i will do it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikeziminio @lostanlen