Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the baudrate NoneType case as "0/AUTO" #12

Closed
wants to merge 1 commit into from
Closed

Handle the baudrate NoneType case as "0/AUTO" #12

wants to merge 1 commit into from

Conversation

FisheyLP
Copy link

Fixes #11

@saschaludwig
Copy link

please merge

@markwal
Copy link
Owner

markwal commented May 14, 2020

I think maybe I accidentally fixed this with my Python 3 compatibility update. The main issue seemed to be the log line was passing None for a int which '%' didn't like. Your change updated it to be %s. Similarly I changed it to untyped placeholders using str.format.

I didn't make similar changes for baudrate like port. port has a "discovered" port and the auto connect set port "autoport" that have to be compared so that we don't try to auto connect to a port that appears, but doesn't match what the auto connect settings say. Baudrate doesn't have the same need since we're just passing the baudrate to the connection request and don't compare it ahead of time.

In any case, it appears to work. Thanks for the pull request. Sorry I've been away for so long.

@markwal markwal closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in do_auto_connect
3 participants