Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destroy #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: destroy #178

wants to merge 1 commit into from

Conversation

unclekitty
Copy link

Add destroy for UI & plugins destroy .

@@ -137,6 +142,10 @@ muya.on('json-change', (_changes) => {
// console.log(JSON.stringify([anchor.offset, focus.offset, path]))
// })

muya.domNode.addEventListener('input', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this listener?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I made a wrong push after submitting the pull request.

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "muya",
"name": "@langh/muya",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I made a wrong push after submitting the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants