Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Commit

Permalink
[msm] determine reversible setting only from matrix if reversible is …
Browse files Browse the repository at this point in the history
…None.

This restores the old behaviour. Fixes #935
  • Loading branch information
marscher committed Sep 21, 2016
1 parent f3917bc commit fd9ad47
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pyemma/msm/models/msm.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,11 @@ def set_model_params(self, P, pi=None, reversible=None, dt_model='1 step', neig=
list of this function (by mandatory or keyword arguments)
"""
# we set reversible first, so it can be derived from P, if None was given.
self.reversible = reversible
if P is not None:
self.P = P
self.pi = pi
self.reversible = reversible
self.dt_model = dt_model
self.neig = neig

Expand All @@ -164,7 +165,8 @@ def P(self, value):
raise ValueError('T is not a transition matrix.')
# set states
self.nstates = _np.shape(self._P)[0]
self.reversible = msmana.is_reversible(self._P, tol=1e-10)
if self.reversible is None:
self.reversible = msmana.is_reversible(self._P)

from scipy.sparse import issparse
self.sparse = issparse(self._P)
Expand Down

0 comments on commit fd9ad47

Please sign in to comment.