Fix Safari CPU on homepage #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying out using a gradient for the image loading placeholder instead of
I also grabbed a clip of it in motion, since it’s only visible for a split second anyway: gradient-in-motion.movIs that the filter or the gradient? I don’t remember! The filename might be wrong! |
|
What I currently have for the hydration animation: hardware-accelerated-partial-hydration.movNot as good as the existing one, but I’m not sure how to get that particular animation while hardware-accelerating it. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes marko-js/website#101
The
.demo-page-loading-linked animations may have to be pure CSSanimation, since Safari is still grumpy about it even if we're just togglingopacity: 0.Hm… or
will-change: opacity. That might help, but pure-CSS would be more efficient than therequestAnimationFramelayer we have right now. That JS was first written for a scroll-linked effect… But now that we're animating a simple loop, full CSS may be the best choice.