Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 13, 2025

Want to see these tests pass before we release ml-gradle 6.1.0. Also fixed one Sonar issue - there are 71 others that I'll handle in separate PRs.

@rjrudin rjrudin requested a review from BillFarber as a code owner October 13, 2025 20:35
Copilot AI review requested due to automatic review settings October 13, 2025 20:35
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Copyright Validation Results
Total: 5 | Passed: 1 | Failed: 0 | Skipped: 4 | at: 2025-10-13 20:59:16 UTC | commit: 63a148b

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • build.gradle
  • docker-compose.yml
  • test-app/build.gradle

✅ Valid Files

  • src/main/java/com/marklogic/kafka/connect/source/XmlPlanInvoker.java

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to use ml-gradle 6.1 snapshot version for testing purposes before the official release, while also addressing a Sonar code quality issue.

  • Updated Gradle task definitions to use the new tasks.register() syntax instead of the legacy task syntax
  • Fixed a Sonar issue by renaming a static logger variable to follow naming conventions
  • Updated Docker Compose service name to be more concise

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
test-app/build.gradle Modernized Gradle task definitions using tasks.register() syntax
src/main/java/com/marklogic/kafka/connect/source/XmlPlanInvoker.java Fixed Sonar issue by renaming logger variable and consolidating imports
docker-compose.yml Updated Docker Compose service name

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

import javax.xml.transform.TransformerConfigurationException;
import javax.xml.transform.TransformerException;
import javax.xml.transform.TransformerFactory;
import javax.xml.transform.*;
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wildcard imports should be avoided as they reduce code readability and can lead to naming conflicts. Consider importing specific classes individually.

Suggested change
import javax.xml.transform.*;
import javax.xml.transform.Transformer;
import javax.xml.transform.TransformerException;
import javax.xml.transform.TransformerFactory;
import javax.xml.transform.TransformerConfigurationException;

Copilot uses AI. Check for mistakes.
Want to see these tests pass before we release ml-gradle 6.1.0. Also fixed one Sonar issue - there are 71 others that I'll handle in separate PRs.
@rjrudin rjrudin merged commit bae80ad into develop Oct 13, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/cleanup branch October 13, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants