MLE-24405 Making ClientCookie a real public class #1825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
requested review from
anu3990,
BillFarber and
stevebio
as code owners
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR moves ClientCookie from the impl package to the public API package and refactors it from a wrapper around OkHttp Cookie to a simple immutable data class holding cookie values directly.
- Moved ClientCookie from
com.marklogic.client.impltocom.marklogic.clientpackage - Simplified ClientCookie implementation to hold cookie values directly instead of wrapping OkHttp Cookie
- Removed unnecessary cloning operations when adding cookies to transactions and sessions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| marklogic-client-api/src/main/java/com/marklogic/client/impl/TransactionImpl.java | Updated import path and removed cookie cloning, fixed typo in comment |
| marklogic-client-api/src/main/java/com/marklogic/client/impl/SessionStateImpl.java | Added import and removed cookie cloning |
| marklogic-client-api/src/main/java/com/marklogic/client/impl/OkHttpServices.java | Added private method to parse cookies and updated calls |
| marklogic-client-api/src/main/java/com/marklogic/client/impl/ClientCookie.java | Deleted old implementation |
| marklogic-client-api/src/main/java/com/marklogic/client/Transaction.java | Removed impl package import |
| marklogic-client-api/src/main/java/com/marklogic/client/ClientCookie.java | New simplified implementation as immutable data class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| private static ClientCookie parseClientCookie(HttpUrl url, String setCookieHeaderValue) { | ||
| Cookie cookie = Cookie.parse(url, setCookieHeaderValue); | ||
| if(cookie == null) throw new IllegalStateException(setCookieHeaderValue + "is not a well-formed cookie"); |
There was a problem hiding this comment.
Missing space in error message. Should be: setCookieHeaderValue + \" is not a well-formed cookie\"
Suggested change
| if(cookie == null) throw new IllegalStateException(setCookieHeaderValue + "is not a well-formed cookie"); | |
| if(cookie == null) throw new IllegalStateException(setCookieHeaderValue + " is not a well-formed cookie"); |
Copilot uses AI. Check for mistakes.
| // make a clone to ensure we're not holding on to any resources | ||
| // related to an HTTP connection that need to be released | ||
| this.cookies.add(new ClientCookie(cookie)); | ||
| this.cookies.add(cookie); |
There was a problem hiding this comment.
Inconsistent indentation. This line uses tabs while the surrounding code uses spaces. Should use spaces to match the existing code style.
Suggested change
| this.cookies.add(cookie); | |
| this.cookies.add(cookie); |
Copilot uses AI. Check for mistakes.
This was already in the public API via the Transaction interface, but it was in the "impl" package. I also can't determine any reason why it was reconstructing an OkHttp Cookie and then holding onto it. The Cookie class is immutable - but ClientCookie was already being given the immutable values that it needed. So no idea why ClientCookie was then rebuilding an OkHttp Cookie. It no longer does that - it's just a simple bean now, holding onto the values of interest that were extracted from an OkHttp Cookie.
rjrudin
force-pushed
the
feature/move-client-cookie
branch
from
d1b6133 to
ab3ea02
Compare
BillFarber
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already in the public API via the Transaction interface, but it was in the "impl" package.
I also can't determine any reason why it was reconstructing an OkHttp Cookie and then holding onto it. The Cookie class is immutable - but ClientCookie was already being given the immutable values that it needed. So no idea why ClientCookie was then rebuilding an OkHttp Cookie. It no longer does that - it's just a simple bean now, holding onto the values of interest that were extracted from an OkHttp Cookie.