-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new React + Node example with Vite #122
Create new React + Node example with Vite #122
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @maxblank-stripe, just following up on this one. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhgilbert great work, thank you! The implementation itself looks good, just left a couple of nits to make the transition from create-react-app
easier for existing users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, one more thing, could you run npm install
and commit the package-lock.json
file as well? node_modules/
folder should be gitignored, but package-lock.json
file is intended to be checked into git.
Co-authored-by: maxblank-stripe <[email protected]>
Co-authored-by: maxblank-stripe <[email protected]>
Co-authored-by: maxblank-stripe <[email protected]>
@maxblank-stripe Suggestions accepted, thank you! I set up a basic build script, let me know if you had something else in mind. The legacy create-react-app example still doesn't have a package.lock, because it didn't before (which is why I omitted the file from my new example as well). But I can add one if you like, just let me know. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
@maxblank-stripe Thanks for the quick turnaround! I don't seem to have merge permission, would you be the person to merge it or should I ask someone else? |
@jhgilbert - we had to bump nodejs version in vercel because the deployment was failing, just merged! Thanks again for your help here! |
As discussed in this issue, I'm working on updating the React + Node example project, since
create-react-app
is deprecated.I used Vite's
react
template and conformed to its defaults. Beyond that, I just tried to stay faithful to the legacy example.@mfix-stripe asked me to keep the legacy example as
create-react-app
, so I've moved the olderreact-nodejs
example to that folder, but nothing in that example has changed.Let me know if you'd prefer a different approach here, or just make edits if that's easier for you. Thank you!