Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade golang-jwt version for apple provider #583

Conversation

burkayanduv
Copy link
Contributor

I was getting token used before issued error with golang-jwt v4, so I've upgraded it to v5. Here is the reference to the issue in the source repository:
Token used before issued #98

This PR updates the Apple provider integration by upgrading the golang-jwt library. Key changes include:

  • Upgraded golang-jwt from v4.2.0 to v5.2.1.
  • Replaced deprecated methods with the new jwt.NewValidator API for token validation.
  • Updated returned error type as jwt.ValidationError was removed in the latest version.

The change in the returned errors will break backwards compatibility if someone has a check on returned error, but that happened in the golang-jwt as well.

@techknowlogick techknowlogick merged commit 0c63ed9 into markbates:master Nov 25, 2024
18 checks passed
@techknowlogick
Copy link
Collaborator

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants