Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup IntelliSense-related behavior #368

Merged
merged 39 commits into from
Jul 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
baf168f
Fixup typo in 3.3.0 changelog
mark-wiemer Jun 21, 2023
3606102
Remove space from trigger char list (#110)
mark-wiemer Jun 21, 2023
e66fcf7
Remove unused code in completionProvider.ts
mark-wiemer Jun 21, 2023
56e23ae
Replace Method.document with Method.uriString
mark-wiemer Jun 21, 2023
0ff333f
Refactor completion items for methods
mark-wiemer Jun 21, 2023
8834a74
Refactor `preChar` calc and add comments
mark-wiemer Jun 21, 2023
c43582f
Cleanup completionProvider so it's testable
mark-wiemer Jun 21, 2023
fd92dd8
Fix parser casing
mark-wiemer Jun 21, 2023
a365131
Document buildScript and Script
mark-wiemer Jun 21, 2023
541de59
Fixup provideCompletionItemsInner docs
mark-wiemer Jun 21, 2023
996e9c8
Update settings descriptions
mark-wiemer Jun 21, 2023
c4d3f34
prefer const
mark-wiemer Jun 21, 2023
a439f7f
cleanup debug dispatcher start
mark-wiemer Jun 21, 2023
16b4a29
WIP deep pick and basic tests
mark-wiemer Jun 21, 2023
0059607
Merge branch 'main' into remove-intellisense
mark-wiemer Jul 27, 2023
882ab1a
Change Omit to Pick
mark-wiemer Jul 27, 2023
a52889f
Fixup completionProvider test
mark-wiemer Jul 29, 2023
eb14b2c
Cleanup API for completion items
mark-wiemer Jul 29, 2023
b7327e8
Fixup types
mark-wiemer Jul 29, 2023
ddad512
a
mark-wiemer Jul 29, 2023
02f8925
fixup comments
mark-wiemer Jul 29, 2023
17e8a96
wip second test
mark-wiemer Jul 29, 2023
fe24a87
fixup intellisense settings
mark-wiemer Jul 29, 2023
8cf6652
note outer tests TBD
mark-wiemer Jul 29, 2023
a1fdb5e
Remove unnecessary async/await
mark-wiemer Jul 29, 2023
fb42b1f
Improve docs for Method class
mark-wiemer Jul 29, 2023
87832e7
Show comma-space separated params in IntelliSense
mark-wiemer Jul 29, 2023
345dd22
Simplify PartialMethod type, removing DeepPick
mark-wiemer Jul 29, 2023
5725a6c
More tests
mark-wiemer Jul 29, 2023
e375a4d
Finalize provideCompletionItemsInner
mark-wiemer Jul 29, 2023
c4725ca
Remove console log
mark-wiemer Jul 29, 2023
f16ccb3
Run all tests, not just new ones!
mark-wiemer Jul 29, 2023
857a84b
Mark format tests for consolidation
mark-wiemer Jul 29, 2023
1e31e8f
Fixup provideDocumentFormattingEdits unused param
mark-wiemer Jul 29, 2023
608d732
Add manual tests to repo, update demo
mark-wiemer Jul 29, 2023
981904f
fixup demos
mark-wiemer Jul 29, 2023
31afa57
Add completion provider manual tests
mark-wiemer Jul 29, 2023
a8f02c1
Change `SharpDirective` to `IfDirective` for clarity
mark-wiemer Jul 29, 2023
0e6a91d
Fixup manual tests
mark-wiemer Jul 29, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"@typescript-eslint/semi": "warn",
"curly": "warn",
"eqeqeq": "warn",
"no-throw-literal": "warn"
"no-throw-literal": "warn",
"prefer-const": "error"
},
"ignorePatterns": ["out", "dist", "**/*.d.ts"]
}
2 changes: 1 addition & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

Fixes:

- Fix several syntax highlighting issues([#85](https://github.com/mark-wiemer/vscode-autohotkey-plus-plus/issues/85), [#318](https://github.com/mark-wiemer/vscode-autohotkey-plus-plus/issues/318))
- Fix several syntax highlighting issues ([#85](https://github.com/mark-wiemer/vscode-autohotkey-plus-plus/issues/85), [#318](https://github.com/mark-wiemer/vscode-autohotkey-plus-plus/issues/318))
- Fix minor debugger issues introduced in 3.1.0 ([#279](https://github.com/mark-wiemer/vscode-autohotkey-plus-plus/issues/279))
- Fix debugging a file with a space in its name ([#134](https://github.com/mark-wiemer/vscode-autohotkey-plus-plus/issues/134))
- Fix formatting for some bad labels (two colons) ([PR #325](https://github.com/mark-wiemer/vscode-autohotkey-plus-plus/pull/325))
Expand Down
106 changes: 0 additions & 106 deletions demos/demo_for_ahk_v1.ahk

This file was deleted.

27 changes: 27 additions & 0 deletions demos/manualTests/completionProvider.ahk
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#Requires AutoHotkey 1.1.33+
#SingleInstance force

; Completion provider manual tests
; Use Ctrl+Space to trigger suggestions

; compTest comment
compTest(p1, p2) {
p3 := 1
; Suggestions within method include locals
p
}

; Suggestions outside of method exclude locals
p

; Default settings (enabled IntelliSense, enabled parsing) shows suggestions
c

; Disabled IntelliSense with enabled parsing shows no suggestions
c

; Enabled IntelliSense with disabled parsing shows no suggestions
c

; Disabled IntelliSense with disabled parsing shows no suggestions
c
12 changes: 12 additions & 0 deletions demos/manualTests/debugger.ahk
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#Requires AutoHotkey 1.1.33+
#SingleInstance force

; Basic debugger test
; Ensure you've run `npm i` before running this test
; 1. Stop on breakpoint
; 2. Step forward works -- Global variables updates
; 3. No errors in Debug Console

x := 1
y := 2 ; Breakpoint here
z := 3
7 changes: 7 additions & 0 deletions demos/manualTests/folding.ahk
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/*
I'm collapsible!
*/

/*
So am I
*/
5 changes: 5 additions & 0 deletions demos/manualTests/hover.ahk
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
; I show up in IntelliSense when hovering only when parsing is enabled
hoverOverMePlease()
{

}
10 changes: 10 additions & 0 deletions demos/manualTests/runSelection.ahk
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#Requires AutoHotkey 1.1.33+
#SingleInstance force

; Select the following line and hit `Ctrl + F8` to run selection
f1:: MsgBox, You hit F1

; Now press F1 and you should see a message box.

; The F2 hotkey will not work because it was not part of the selection
f2:: MsgBox, You hit F2
Loading