Skip to content

t18652: fix(lint): resolve headless prompt defaults from agents root for deployed bundles (GH#34296) - #34297

Merged
marcusquinn merged 1 commit into
mainfrom
bugfix/t18652-prompt-lint-deployed-layout
Oct 10, 2026
Merged

marcusquinn merged 1 commit into
mainfrom
bugfix/t18652-prompt-lint-deployed-layout

Conversation

@marcusquinn

Copy link
Copy Markdown
Owner

Summary

prompt-command-policy-lint.py resolved its default headless prompts from REPO_ROOT / ".agents/workflows/...". That works in a source checkout but fails in a deployed runtime bundle (~/.aidevops/agents/), where there is no .agents/ path segment. Defaults now resolve from AGENTS_DIR (the script's parent directory), matching how --policy was already resolved.

Resolves #34296
Ref #34295

Changes

  • .agents/scripts/prompt-command-policy-lint.py: add AGENTS_DIR = SCRIPT_DIR.parent; HEADLESS_PROMPTS are relative to it (workflows/pulse.md, workflows/pulse-sweep.md); default files and --policy use AGENTS_DIR. Explicit file arguments and fail-closed handling are unchanged.

Verification

  • Source layout: python3 .agents/scripts/prompt-command-policy-lint.py → pulse.md: 0 forbidden of 20, pulse-sweep.md: 0 forbidden of 23, exit 0.
  • Deployed layout (copied agents/ bundle): the unpatched script exits 1 on missing <bundle>/.agents/workflows/*.md; the patched script passes both prompts.
  • Fail-closed: with pulse-sweep.md removed from the copied bundle, the patched lint reports No such file or directory and exits 1.
  • bash .agents/scripts/tests/test-command-policy-helper.sh → Tests: 224, Failures: 0.
  • python3 -m py_compile clean.

aidevops.sh v3.39.1 plugin for OpenCode v1.18.35 with claude-opus-5-5 spent 6h 2m and 634,878 tokens on this with the user in an interactive session.

@marcusquinn marcusquinn added the origin:interactive Created by interactive user session label Oct 10, 2026
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

🚫 Excluded labels (none allowed) (1)
  • no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: marcusquinn/aidevops/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ff668a50-68cc-4d54-ad93-50577c6c8ccb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions

Copy link
Copy Markdown
Contributor

Bash 3.2 Compatibility Regression Gate

✅ No regression — no new bash 3.2-incompatible construct(s).

Metric Base (c49f661) Head (c58390c)
Total bash 3.2-incompatible construct(s) 0 0

@github-actions

Copy link
Copy Markdown
Contributor

Qlty Smell Regression Gate

✅ No change — smell count unchanged.

Metric Base (c49f661) Head (c58390c) Delta
Total smells 65 65 +0

@github-actions

Copy link
Copy Markdown
Contributor

Shell Function Complexity Regression Gate

✅ No regression — no new function(s) >100 lines.

Metric Base (c49f661) Head (c58390c)
Total function(s) >100 lines 0 0

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells

Sat Oct 10 23:37:41 UTC 2026: Code review monitoring started
Sat Oct 10 23:37:41 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 1
Sat Oct 10 23:39:45 UTC 2026: Codacy analysis completed - issues found (exit 1)

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 1
  • VULNERABILITIES: 0

Generated on: Sat Oct 10 23:39:46 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@github-actions

Copy link
Copy Markdown
Contributor

Shell Nesting Depth Regression Gate

✅ No regression — no new file(s) with nesting depth >8.

Metric Base (c49f661) Head (c58390c)
Total file(s) with nesting depth >8 0 0

@github-actions

Copy link
Copy Markdown
Contributor

File Size Regression Gate

✅ No regression — no new non-README Markdown file(s) >1000 lines at root / >500 elsewhere.

Metric Base (c49f661) Head (c58390c)
Total non-README Markdown file(s) >1000 lines at root / >500 elsewhere 0 0

@marcusquinn
marcusquinn marked this pull request as ready for review October 10, 2026 23:46
@marcusquinn
marcusquinn merged commit 3ce6354 into main Oct 10, 2026
62 of 63 checks passed
@marcusquinn
marcusquinn deleted the bugfix/t18652-prompt-lint-deployed-layout branch October 10, 2026 23:47
@github-actions github-actions Bot added the status:done Task is complete label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:interactive Created by interactive user session status:done Task is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t18652: fix(lint): prompt-command-policy-lint default prompts fail in deployed runtime bundles

1 participant