Repository navigation
t18652: fix(lint): resolve headless prompt defaults from agents root for deployed bundles (GH#34296) - #34297
Conversation
…t for deployed bundles
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Bash 3.2 Compatibility Regression Gate✅ No regression — no new bash 3.2-incompatible construct(s).
|
Qlty Smell Regression Gate✅ No change — smell count unchanged.
|
Shell Function Complexity Regression Gate✅ No regression — no new function(s) >100 lines.
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells Sat Oct 10 23:37:41 UTC 2026: Code review monitoring started 📈 Current Quality Metrics
Generated on: Sat Oct 10 23:39:46 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
Shell Nesting Depth Regression Gate✅ No regression — no new file(s) with nesting depth >8.
|
File Size Regression Gate✅ No regression — no new non-README Markdown file(s) >1000 lines at root / >500 elsewhere.
|
Summary
prompt-command-policy-lint.pyresolved its default headless prompts fromREPO_ROOT / ".agents/workflows/...". That works in a source checkout but fails in a deployed runtime bundle (~/.aidevops/agents/), where there is no.agents/path segment. Defaults now resolve fromAGENTS_DIR(the script's parent directory), matching how--policywas already resolved.Resolves #34296
Ref #34295
Changes
.agents/scripts/prompt-command-policy-lint.py: addAGENTS_DIR = SCRIPT_DIR.parent;HEADLESS_PROMPTSare relative to it (workflows/pulse.md,workflows/pulse-sweep.md); defaultfilesand--policyuseAGENTS_DIR. Explicit file arguments and fail-closed handling are unchanged.Verification
python3 .agents/scripts/prompt-command-policy-lint.py→pulse.md: 0 forbidden of 20,pulse-sweep.md: 0 forbidden of 23, exit 0.agents/bundle): the unpatched script exits 1 on missing<bundle>/.agents/workflows/*.md; the patched script passes both prompts.pulse-sweep.mdremoved from the copied bundle, the patched lint reportsNo such file or directoryand exits 1.bash .agents/scripts/tests/test-command-policy-helper.sh→Tests: 224, Failures: 0.python3 -m py_compileclean.aidevops.sh v3.39.1 plugin for OpenCode v1.18.35 with claude-opus-5-5 spent 6h 2m and 634,878 tokens on this with the user in an interactive session.