Fix #41 - New feature allowing to set the connection timeout option#42
Open
Ljz7 wants to merge 1 commit intomarcushat:masterfrom
Open
Fix #41 - New feature allowing to set the connection timeout option#42Ljz7 wants to merge 1 commit intomarcushat:masterfrom
Ljz7 wants to merge 1 commit intomarcushat:masterfrom
Conversation
…CTTIMEOUT(_MS) option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #41 :
It's because of the addition of connect timeout and timeout. The /src/rollingcurlx.class.php lines 153 to 163 set both options to the value of the property
_timeout. So, the max total time for a request is_timeout * 2.This is a simple fix to allow users to set the timeout and the connection timeout.