Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogleft plus linuxcore #5

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

danubie
Copy link

@danubie danubie commented Oct 11, 2021

This branch takes care for compatibility running under PSCore on Linux.
Additionally it reintroduces all enhancements done by @dogleft while keeping the rules of the original module (e.g. naming conventions, prefix, ...).

Changes / Enhancements refactored (Kudos go to @dogleft)

  • Added maintenance functions (New \ Get \ Remove)
  • Added unit tests for the functions needed immediately and refactored to separate files to simplify debugging and maintenance
  • Fixed small bugs as the unit tests exposed them
  • Moved the sprawl of files into subfolders to keep the top level clean

Additional changes

  • modify all paths to be linux-compatible and relative to PSZabbix root folder
  • Split functions into seperate folders for private/public
  • Add config for VSCode devcontainer (to locally develop for PSCore and )
  • Adopt tests to Pester v5 Syntax
  • Add Test for general module checks

@danubie
Copy link
Author

danubie commented Oct 11, 2021

Some more comments on my PR

  • Version number 1.4.1
    • I don't know how your pipeline to the gallery works, but I guess this could be a good choice. Because users which manually installed doglefts version would have got a 1.4.0
  • Pester tests
    • all module tests have been run successful unter Windows 10 (PS5.1 & PS7.1.4) and Ubuntu-Linux (PS7.1.4)
    • integration tests
      Currently PSZabbix.Tests.ps1 can now run under Pester V5. V5 has some major changes (particularly in scoping of mocks and variables).
      So this tests can be run, but some will fail. In my environment, this is the case with the tests in the master branch as well. It looks like some parameters rely on data which is not present in a default installation of Zabbix.

Thus, keeing an eye on (modifiying) the integration test to get clean results would be my next goal. As long as you want me to go on in this direction.

Regards, Wolfgang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant