Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency bump and re-bless #1641

Merged
merged 21 commits into from
Jan 5, 2025

Conversation

CommanderStorm
Copy link
Collaborator

This PR re-blesses the output and does #1632 (comment)

martin/src/args/root.rs Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm marked this pull request as draft January 4, 2025 16:23
@CommanderStorm
Copy link
Collaborator Author

CommanderStorm commented Jan 4, 2025

To be transparent what is happening in the git history:
I am having trouble reproducing the build faliour in CI locally.
This is because I am not running node 16 (as CI does). Because vite@v6 is using structuredClone, node>=17 would be required.

Bumping the node version in CI is not quite working:
image

=> currently trying out how other node versions are/are not able to be installed ^^

A patch would be to revert to vite@v5

@CommanderStorm
Copy link
Collaborator Author

Okay. vite@v5 and node@17 seem to be the most recent that I can push this to without totally changing the way we write our docker files.

TBH, we should likely move the building of the binary into docker anyway, to eliminate libc-issues with node>=18.
That is a different PR though.

@CommanderStorm CommanderStorm marked this pull request as ready for review January 5, 2025 02:42
@CommanderStorm CommanderStorm requested a review from nyurik January 5, 2025 02:43
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@CommanderStorm CommanderStorm merged commit 1540791 into maplibre:main Jan 5, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants