Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and bless #1639

Merged
merged 6 commits into from
Jan 4, 2025
Merged

Cleanup and bless #1639

merged 6 commits into from
Jan 4, 2025

Conversation

sharkAndshark
Copy link
Collaborator

@sharkAndshark sharkAndshark commented Jan 2, 2025 •
edited
Loading

  • Add some comments
  • Add a warn when ignoring a mask subfile
  • Fix failed test(args/root.rs)
  • Move some verifications to a standalone verify_requirments function
  • Remove unused errors

sharkAndshark
sharkAndshark commented Jan 2, 2025
View reviewed changes
martin/src/cog/mod.rs
decoder
.seek_to_image(*image_ifd)
.map_err(|e| CogError::IfdSeekFailed(e, *image_ifd, path.clone()))?;

let zoom = u8::try_from(images_ifd.len() - (image_ifd + 1))
let zoom = u8::try_from(images_ifd.len() - (idx + 1))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of images_ifd.len() - (image_ifd + 1) would be wrong when there are masks. Updated this to images_ifd.len() - (idx + 1)

@sharkAndshark sharkAndshark marked this pull request as ready for review January 2, 2025 08:57
@sharkAndshark sharkAndshark requested a review from nyurik January 2, 2025 08:58
CommanderStorm
CommanderStorm approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge as far as I am concearned.
Lets just make sure that the metadata changes are correct. ^^

martin/src/cog/mod.rs Show resolved Hide resolved
martin/src/cog/mod.rs Show resolved Hide resolved
@sharkAndshark sharkAndshark merged commit a70d971 into maplibre:main Jan 4, 2025
17 of 18 checks passed
@sharkAndshark sharkAndshark deleted the cleanup branch January 4, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommanderStorm CommanderStorm CommanderStorm approved these changes

@nyurik nyurik Awaiting requested review from nyurik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkAndshark @CommanderStorm