Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency to surface updates #3056

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

adrian-cojocaru
Copy link
Collaborator

Surface rotation events (and updated info) come a few frames later after 90 degree rotations. Adding a delay between the event and surface update fixes #2787 (comment)

Copy link

github-actions bot commented Nov 28, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0089         -0.0092             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3056-compared-to-main.txt

Copy link

github-actions bot commented Nov 28, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3056-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.5Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3056-compared-to-legacy.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review November 28, 2024 19:08
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also how games and the like solve this problem?

@adrian-cojocaru
Copy link
Collaborator Author

I'm not sure if it's the best solution, but I've seen this type of fix a few times.

Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3056-compared-to-main.txt

Copy link
Collaborator

@TimSylvester TimSylvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. It might be a good idea to include an explicit recursion limit just in case the SDK doesn't behave as expected.

@louwers louwers merged commit c548212 into maplibre:main Dec 3, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Vulkan Early Access Testing (Android)
3 participants