Fix the issue that the empty polyline cannot be updated

[grab-liyanjin]

An example code to reproduce the issue is

Polyline line = mapLibreMap.addPolyline(new PolylineOptions());
// Anything to update the polyline will fail
line.setPoints(...);
line.setColor(...);

The reason is that PolylineContainer will ignore the empty polyline the first time.

[hactar]

Hmm, I wonder why that check was there in the first place...

Did you test what happens if you add an empty polyline and don't add any points/colors etc later in the code?

[louwers]

Thanks for the PR!!

We should probably make this behavior consistent across other types of containers. For example:

maplibre-native/platform/android/MapLibreAndroid/src/main/java/org/maplibre/android/maps/PolygonContainer.java

Lines 30 to 35 in 06fb181

	if (!polygon.getPoints().isEmpty()) {
	long id = nativeMap != null ? nativeMap.addPolygon(polygon) : 0;
	polygon.setId(id);
	polygon.setMapLibreMap(maplibreMap);
	annotations.put(id, polygon);
	}

Also there is a AnnotationManagerTest.kt where a test can be added.

[grab-liyanjin]

Hmm, I wonder why that check was there in the first place...

Did you test what happens if you add an empty polyline and don't add any points/colors etc later in the code?

This issue was found by our developer during map integration, nothing will happen with empty point, but cannot update the polyline later since it's not really added into the map

[grab-liyanjin]

Thanks for the PR!!

We should probably make this behavior consistent across other types of containers. For example:

maplibre-native/platform/android/MapLibreAndroid/src/main/java/org/maplibre/android/maps/PolygonContainer.java

Lines 30 to 35 in 06fb181

	if (!polygon.getPoints().isEmpty()) {
	long id = nativeMap != null ? nativeMap.addPolygon(polygon) : 0;
	polygon.setId(id);
	polygon.setMapLibreMap(maplibreMap);
	annotations.put(id, polygon);
	}

Also there is a AnnotationManagerTest.kt where a test can be added.

Hi louwers, I checked all the containers including PolygonContainer, PolylineContainer, MarkerContainer, AnnotationContainer, and ShapeAnnotationContainer, only PolygonContainer and PolylineContainer have this kind of logic, so made changes to these two classes and UT as well