Allow configuring Call.Factory instead of OkHttpClient (#3137) #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to configure a `Call.Factory` instead of just an `OkHttpClient` for making HTTP requests. It introduces a new `setOkHttpCallFactory` method in `HttpRequestUtil` and deprecates the `setOkHttpClient` method. This change provides more flexibility and allows users to use different HTTP clients, like those using Cronet.
louwers
reviewed
Nov 2, 2024
.../android/MapLibreAndroid/src/main/java/org/maplibre/android/module/http/HttpRequestImpl.java
Outdated
Show resolved
Hide resolved
louwers
approved these changes
Nov 4, 2024
|
Thank you, will be part of the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to configure a
Call.Factoryinstead of just anOkHttpClientfor making HTTP requests. It changes thesetOkHttpClientmethod in a source compatible, but binary incompatible way.This change provides more flexibility and allows users to use different HTTP clients, like those using Cronet.
Closes #2986