Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tile ID methods noexcept #1828

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Mark tile ID methods noexcept #1828

merged 2 commits into from
Oct 31, 2023

Conversation

TimSylvester
Copy link
Collaborator

Cherry-picked to a separate PR from #1792

(cherry picked from commit e2624f8)
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4184517) 85.79% compared to head (998a432) 85.79%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         566      566           
  Lines       27856    27857    +1     
=======================================
+ Hits        23900    23901    +1     
  Misses       3956     3956           
Files Coverage Δ
src/mbgl/util/hash.hpp 100.00% <100.00%> (ø)
src/mbgl/tile/tile_id_hash.cpp 68.75% <66.66%> (ø)
include/mbgl/tile/tile_id.hpp 95.55% <92.85%> (+0.04%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0% -67.1Ki  -0.0% -9.08Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1828-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +19% +22.0Mi  +401% +24.0Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1828-compared-to-legacy.txt

@TimSylvester TimSylvester merged commit 5a17559 into main Oct 31, 2023
36 checks passed
@TimSylvester TimSylvester deleted the tileid-noexcept branch October 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants