Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MapTiler Satellite Tile Source #1087

Closed
wants to merge 2 commits into from

Conversation

dpaulat
Copy link
Contributor

@dpaulat dpaulat commented Apr 30, 2023

When using MapTiler as the tile server, satellite map tiles do not display properly (using mbgl-qt as a reference):

2023-04-29 09_01_57-MapLibre GL_ Satellite Hybrid

When updating the source template:

- .withSourceTemplate("/tiles{path}/tiles.json", "sources", {})
+ .withSourceTemplate("/maps{path}/tiles.json", "sources", {})

The satellite map tiles display as expected.

2023-04-29 22_24_27-MapLibre GL_ Satellite Hybrid

From what I can tell, everything seems to work, but I'm concerned I'm missing something. Some documents reference tiles.json at the old path (e.g., standard tiles), and some at the new path (e.g., raster tiles for standard styles).

Standard tiles with the old path: https://cloud.maptiler.com/tiles/
Standard styles with the new path: https://cloud.maptiler.com/maps/

Any thoughts?

@dpaulat
Copy link
Contributor Author

dpaulat commented Apr 30, 2023

It looks like the MapTiler.SourceURL test failed as a result. The existing functionality is not clear to me at this stage, but I suspect the change required is going to be more complicated.

@louwers
Copy link
Collaborator

louwers commented Apr 30, 2023

@dpaulat Thanks for this PR.

It's not a priority for us to fix this. We can merge a fix, but over time we want to move away from including vendor-specific code at all.

If you are a MapTiler customer it is best to contact them directly. (cc @klokan)

@louwers louwers closed this May 1, 2023
@louwers louwers reopened this May 1, 2023
@ntadej
Copy link
Collaborator

ntadej commented Oct 29, 2023

It seems that production MapTiler paths still use /tiles. I think we should probably close the PR.

@dpaulat, did you manage to solve the issue in the meantime?

@dpaulat
Copy link
Contributor Author

dpaulat commented Oct 29, 2023

I agree, changing from /tiles causes some other issues. I still have issues with satellite maps, so I think there's still some improvement that can be made, although I don't think my solution is the correct one. I've worked around the issue on a fork. Let's go ahead and close this PR without merge.

@ntadej ntadej closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants