Fix inline-block bug and prepare 2.3.1

mapbox · Feb 8, 2023 · 692025e · 692025e
1 parent aa82d91
commit 692025e
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## Changelog
 
+## 2.3.1
+
+- [bug] Fix layout bug introduced in copy-button changes where wrapper was given `inline-block`
 
 ## 2.3.0
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@mapbox/mr-ui",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "UI components for Mapbox projects",
   "main": "index.js",
   "homepage": "./",

diff --git a/src/components/code-snippet/__snapshots__/code-snippet.test.tsx.snap b/src/components/code-snippet/__snapshots__/code-snippet.test.tsx.snap
@@ -339,7 +339,6 @@ exports[`CodeSnippet copy ranges renders as expected 1`] = `
               aria-controls="radix-4"
               aria-expanded="false"
               aria-haspopup="dialog"
-              class="inline-block"
               data-state="closed"
               type="button"
             >
@@ -393,7 +392,6 @@ exports[`CodeSnippet copy ranges renders as expected 1`] = `
               aria-controls="radix-5"
               aria-expanded="false"
               aria-haspopup="dialog"
-              class="inline-block"
               data-state="closed"
               type="button"
             >
@@ -630,7 +628,6 @@ exports[`CodeSnippet highlighted, no ranges, with onCopy callback renders as exp
               aria-controls="radix-0"
               aria-expanded="false"
               aria-haspopup="dialog"
-              class="inline-block"
               data-state="closed"
               type="button"
             >

diff --git a/src/components/copy-button/__snapshots__/copy-button.test.tsx.snap b/src/components/copy-button/__snapshots__/copy-button.test.tsx.snap
@@ -16,7 +16,6 @@ exports[`CopyButton all props renders as expected 1`] = `
           aria-controls="radix-4"
           aria-expanded="false"
           aria-haspopup="dialog"
-          class="inline-block"
           data-state="closed"
           type="button"
         >
@@ -48,7 +47,6 @@ exports[`CopyButton basic renders as expected 1`] = `
           aria-controls="radix-0"
           aria-expanded="false"
           aria-haspopup="dialog"
-          class="inline-block"
           data-state="closed"
           type="button"
         >

diff --git a/src/components/copy-button/copy-button.tsx b/src/components/copy-button/copy-button.tsx
@@ -130,7 +130,7 @@ export default function CopyButton({
         hideWhenAnchorIsOffscreen={true}
         padding="small"
       >
-        <div className="inline-block"> 
+        <div> 
           <Tooltip
             disabled={showingFeedback}
             coloring={themeTooltip}

diff --git a/src/components/copy-button/examples/copy-button-c.tsx b/src/components/copy-button/examples/copy-button-c.tsx
@@ -6,8 +6,10 @@ import CopyButton from '../copy-button';
 
 export default function Example() {
   return (
-    <CopyButton themeTooltip="dark" text="Some copy from the custom element">
-      <button className="w240 btn">Just a custom element</button>
-    </CopyButton>
+    <div className="inline-block">
+      <CopyButton themeTooltip="dark" text="Some copy from the custom element">
+        <button className="w240 btn">Just a custom element</button>
+      </CopyButton>
+    </div>
   );
 }