-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question about remark-lint-mapbox
. Looks good!
package.json
Outdated
@@ -84,6 +84,7 @@ | |||
"@elastic/search-ui-site-search-connector": "1.7.0", | |||
"@mapbox/mapbox-gl-supported": "^2.0.1", | |||
"@mapbox/mr-ui": "^2.7.0", | |||
"@mapbox/remark-lint-mapbox": "^4.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be explicitly added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I believe this was left over from my forced update to remark-lint-mapbox
in order to have access to the new content type. This packages is already a dependency of remark-config-docs
but rather than wait for dependabot to push an updated release (24 hrs?) I ran npm i @mapbox/remark-lint-mapbox@latest --force
and I believe that's what added this. I was following the release instructions here.
I've removed this in the my most recent commit and remark-config-docs
should have the most recent version (if the former release process is still working)
@chriswhong Updates on this last PR. The changes needed to make the Lastly, I had issues trying to work around the I'm happy to pair on that with you to help me understand, or keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a commit to avoid the arrow function/eslint ignore issue in card.js
This PR introduces a new content type for Mapbox docs. The 'FAQ' content type.
help-card-data.js
mbx-assembly-docs
to unlock a new color for this new content type.EDIT
card.js
component.