Options to not close browser on finish and/or on error.

[dmwyatt]

I know in mantoni/mochify.js#77 you metioned closeOnFailure, but but closeOnFinish was easy to implement and I can foresee use cases for exploring problems.

As you mentioned on the other issue, this defaults to closing the browser when done, but if you set closeOnFinish/closeOnError option to false, it will leave browser open.

[mantoni]

Very nice. I like the option names and the separation into two options makes sense as well.

Regarding closeOnFinish: This sounds a bit like it's never going to close regardless of whether an error occurred or not. It could be either renamed to closeOnSuccess or it could implicitly set closeOnError to false as well.

From looking at the diff, I think there should be an else case for all the new ifs that invoke the callback function immediately.

What do you think?

[dmwyatt]

Something like this?

    if (err && context.closeOnError) {
      close(context, function () {
        callback(err);
      });
      return;
    } else if(err) {
      callback(err);
    }

[mantoni]

Yes. Exactly.

[dmwyatt]

I think that's workable. I changed the if/else I talked about in my last comment a tiny bit to something I like the looks of more, but anyway, there we go.

I think. 😄

[mantoni]

Thanks 👍

[mantoni]

Released in v2.3.0. Happy testing!