Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the template defintions to end in hxx #39087

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Mar 20, 2025

This is a more standard extension than tcc as described in https://stackoverflow.com/questions/5612791/c-template-and-header-files. It also changes a doxygen string now that doxygen recognizes the filetype. The .gitignore was edited to discourage people from using the .tcc extension.

There is no associated issue.

To test:

If it compiles, it works.

This does not require release notes because it is a very internal change to aid compilers and IDEs understand the file's purpose better.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly label Mar 20, 2025
@peterfpeterson peterfpeterson added this to the Release 6.13 milestone Mar 20, 2025
@peterfpeterson peterfpeterson changed the title Rename the template defnitions to end in hxx Rename the template defintions to end in hxx Mar 20, 2025
Copy link
Contributor

@rboston628 rboston628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are obvious, except the doxygen changes. Those look good, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants