Basic Instrument View functionality with PyVista #39081
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spherical and cylindrical, using matplotlib
Also added a couple of tests. One existing test was clearing the ADS for the whole test class, which means the tests would pass/fail depending on the order they ran, so I've fixed that as well.
The file to load is now an argument when launching the instrumentview module. It also now uses the more general Load algorithm, instead of the separate algorithm, e.g. LoadEventNexus
New toggle will allow user to draw a rectangle and select all detectors within that rectangle. Drawing the rectangle or not is toggled with the 'r' key (set by PyVista).
When running the instrumentview module separately to Workbench, set the application icon to something Mantid.
The QTextEdit handles longer text better than a QLineEdit, now we'll get a scroll wheel when the text from the selected detector(s) is too long for one line.
jclarkeSTFC
added
the
ISIS Team: Core
for more information, see https://pre-commit.ci
jclarkeSTFC
force-pushed
the
pyvista_test
branch
from
323d362 to
d4f22b9
Compare
jclarkeSTFC
force-pushed
the
pyvista_test
branch
from
a90c5de to
f0215dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
Fixes #38364
Fixes #38424
Fixes #38422
Fixes #38421
Fixes #38427
Fixes #38423
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.