Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of Miniforge #39031

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Mar 7, 2025

Update to the newest version of Miniforge. Mambaforge no longer exists, so rename all instances.

Fixes #38848

To test:

  • Check docs are alright
  • Check for typos
  • Check that builds are OK
  • Search codebase for mambaforge and verify that all instances have been removed.
  • Verify that this test job was fine

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

thomashampson and others added 2 commits March 7, 2025 15:48
@jclarkeSTFC jclarkeSTFC added this to the Release 6.13 milestone Mar 10, 2025
@jclarkeSTFC
Copy link
Contributor

When this gets merged in, I think all the build machines will need cleaning, mainly just build/CMakeCache.txt.

@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review March 10, 2025 10:48
@thomashampson thomashampson force-pushed the 38848_mambaforge_to_miniforge branch from 8ce3e23 to 55d5326 Compare March 14, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from mambaforge to miniforge
2 participants