Skip to content

Commit

Permalink
Fixes issue #51 - Move SonarCloud into the build workflow (#52)
Browse files Browse the repository at this point in the history
  • Loading branch information
mnriem authored Feb 17, 2023
1 parent 962e46b commit 77a057c
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 26 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,21 @@ jobs:
java-version: 17
- name: Build with Maven
run: mvn -B -DskipTests package
sonarcloud:
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v2
- name: Set up Java
uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 17
- name: Analyze with SonarCloud
run: |
mvn -B -DskipTests -ntp install verify site \
sonar:sonar -Dsonar.projectKey=manorrock_guppy \
-Dsonar.organization=manorrock-1 -Dsonar.host.url=https://sonarcloud.io \
-Dsonar.login=${{ secrets.SONAR_TOKEN }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
24 changes: 0 additions & 24 deletions .github/workflows/sonarcloud.yml

This file was deleted.

4 changes: 2 additions & 2 deletions environment/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M4</version>
<version>3.0.0-M8</version>
<configuration>
<environmentVariables>
<GUPPY_ENVIRONMENT.0.URL>jdbc:h2:mem:test</GUPPY_ENVIRONMENT.0.URL>
Expand All @@ -35,7 +35,7 @@
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
<version>2.1.210</version>
<version>2.1.214</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down

0 comments on commit 77a057c

Please sign in to comment.