-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue 166 #196
base: master
Are you sure you want to change the base?
Fix for Issue 166 #196
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@tinajohnson As discussed, any chance you can review this? |
Hey @digitalsleuth, |
Hi @tinajohnson , I wouldn't be opposed to helping out, however I don't have as much of a familiarity with the entirety of the code as you or someone else might have. If it's simply a matter of removing Do you have any tests which execute each function already available to that I might be able to use to test with? Aside from that, I do have another PR in the chamber ready to submit for another error, but I wanted to wait until I could get fakenet running again with this PR before I submit any others. |
Hi @tinajohnson , I've reviewed the similar calls to |
Thank you, I appreciate it. As for testing the code, you can use |
The error identified in #166 is caused when attempting to log
e.message
, howevere
does not actually have an attributemessage
. This PR removes the.message
from the call toe
, resolving the issue. Solution here is originally credited to the author of the issue.