use _yield from []_ to create empty generator when needed #2572

[dhruvak001]

The issue#2572 arises from an old trick of making a function behave as a generator by using if False: yield .... The correct and idiomatic solution is to replace such patterns with yield from [], which is clean, efficient, and easy to understand.

• No CHANGELOG update needed
• No new tests needed
• No documentation update needed

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

CHANGELOG updated or no update needed, thanks! 😄

[dhruvak001]

use yield from [] to create empty generator when needed #2572

[williballenthin]

the old pattern was originally used to support Python 2.7 which didn't have yield from .... Now that we're safely beyond that version, this is a much better solution.

[williballenthin]

@dhruvak001 are there any other parts of the codebase with a similar pattern that needs updating?

[dhruvak001]

@williballenthin i don't think so as far as I have seen.

[dhruvak001]

@williballenthin can u please review it?

[williballenthin]

looks good. please address the linter failures.

[dhruvak001]

mandiant/capa-rules#988

@williballenthin plz check out the above PR in capa-rules for linter failures update.

[williballenthin]

code style/black is failing. would you please fix the python file formatting?

[dhruvak001]

All Done @williballenthin

[williballenthin]

please update the submodule back to master@capa-rules can we can merge this.

[dhruvak001]

@williballenthin updated the submodule to the again the master @capa-rules, but again the rule linter check failed.

[williballenthin]

but again the rule linter check failed

thats expected at the moment and won't be a blocker here. the issues are unrelated to the changes in this PR.

[williballenthin]

please also make similar changes:

• https://github.com/mandiant/capa/blob/master/capa/features/extractors/pefile.py#L120
• https://github.com/mandiant/capa/blob/master/capa/features/extractors/drakvuf/extractor.py#L80

[williballenthin]

thank you @dhruvak001!

[williballenthin]

our linters fail in master due to the hex casing changes in this PR:
https://github.com/mandiant/capa/actions/runs/13115215108/job/36587777073?pr=2586

i will revert those changes