Skip to content

Fix response possibly undefined TS error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgllm
Copy link

@rgllm rgllm commented Mar 17, 2025

Currently the project does not build due to a TS error because response is possible undefined on manager.fetch, this PR fixes the issue.

@kuba-orlik
Copy link

@rgllm, thanks for the heads-up! I tried to build the project using the latest main branch and I don't see any errors during npm run build or npm run typecheck. Could you provide some more details on what error did you see, where and when?

@rgllm
Copy link
Author

rgllm commented Mar 21, 2025

@rgllm, thanks for the heads-up! I tried to build the project using the latest main branch and I don't see any errors during npm run build or npm run typecheck. Could you provide some more details on what error did you see, where and when?

Sorry, I should have added more details about my env. It's only happening with pnpm, all good with npm for me too.

pnpm 10.3.0
node 22.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants