-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a skeleton driver for IBM InfoWindow 3477 #13332
base: master
Are you sure you want to change the base?
Conversation
New systems marked not working ------------------------------ IBM InfoWindow 3477 [OldComputers ES]
src/mame/ibm/ibm3477.cpp
Outdated
ROM_LOAD("pn_38f5843_ibm_30-10-89.zm12", 0x00000, 0x20000, CRC(b07efb93) SHA1(84d245d17828bc4e096e0cae2d066f2209f56a8f) ) | ||
ROM_LOAD("pn_38f5844_ibm_20-10-89.zm13", 0x20000, 0x20000, CRC(05f3c0f6) SHA1(f99096a2f3e97fe1eb540db3f3e620ddccf71bbc) ) | ||
|
||
ROM_REGION( 0x2000, "chargen", 0 ) | ||
ROM_LOAD( "char.bin", 0x0000, 0x2000, NO_DUMP ) // probably inside the video processor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has an attempt been made for the roms to checkout if they gfxdecode
cleanly with a 1bpp linear layout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before your machine_config
:
static GFXDECODE_START( gfx_ibm3477 )
GFXDECODE_ENTRY("maincpu", 0x0000, gfx_8x8x1, 0, 1)
GFXDECODE_END
Then, in your machine_config, around palette declaration:
GFXDECODE(config, "gfxdecode", "palette", gfx_ibm3477);
F4 menu, press enter once, scroll down with directional arrows and check if there's some kind of clear GFX in there. If it does then the HW has some kind of Programmable Character Generator so the NO_DUMP
is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last pic shows enough to suspect this using a PCG yes, so please just remove that NO_DUMP
flag, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks a lot!!
src/mame/ibm/ibm3477.cpp
Outdated
|
||
private: | ||
virtual void machine_reset() override ATTR_COLD; | ||
void ibm3477_palette(palette_device &palette) const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
palette_init
please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Thanks!
src/mame/ibm/ibm3477.cpp
Outdated
uint32_t screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect); | ||
|
||
required_device<cpu_device> m_maincpu; | ||
required_region_ptr<u8> m_p_chargen; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m_p_chargen lines needs removing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opppps! Fixed, thanks
New systems marked not working
IBM InfoWindow 3477 [OldComputers ES]