Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oberheim_dmx.lay: Proper tracking of pointer IDs. Easier fine adjustments. #13319

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

m1macrophage
Copy link
Contributor

  • Click and adjustment state is now tracked for each pointer ID individually, rather than globally.
  • If a user selects the slider knob, the adjustment will be proportional to the knob movement. This allows for finer adjustments. If the user clicks elsewhere on the slider, the adjustment is based on the absolute position of the click.

This is a followup to the discussion in #13177. Tested on a single-mouse setup.

This should also work with multiple pointer devices, and touchscreens (assuming the latter generate "button press" events). But I was not able to verify. I tried testing with multiple mouse cursors (using xinput and multiple mice), but it seems like SDL2 does not support that. I also tried emulating a touchscreen with evdev, but this didn't work either. If someone has a way to test multiple cursors or emulate a touchscreen on linux, let me know. Alternatively, if someone with a touchscreen can validate, that would be great!

…ents.

- Click and adjustment state is now tracked for each pointer ID individually,
  rather than globally.
- If a user selects the slider knob, the adjustment will be proportional to
  the knob movement. This allows for finer adjustments. If the user clicks
  elsewhere on the slider, the adjustment is based on the absolute position
  of the click.
@galibert
Copy link
Member

galibert commented Feb 2, 2025 via email

@m1macrophage
Copy link
Contributor Author

Thanks for taking a look! To rule out the script itself as the source
of weirdness, consider running with -enable_touch -noplugin layout. Sliders
won't work of course, but if you are able to reproduce the issue with the pads,
then the source of weirdness might be elsewhere.

@galibert
Copy link
Member

galibert commented Feb 2, 2025

Yeah, the issue is elsewhere. And I solved the weirdness: the mame mouse moves by exactly how much you moved the finger while touching, but in one step once you release the touch.

Still needs to be solved before (multi?) touched is fully usable. It's very nice to have a real driver to try with.

@galibert galibert merged commit 5d2170d into mamedev:master Feb 3, 2025
5 checks passed
@m1macrophage m1macrophage deleted the dmxlayout branch February 4, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants