default console logging to false #665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this PR has not received any attention yet. @malsup I really hope you will consider this. Verbose logging should really be opt-in, as is is with nearly every jQuery plugin I've seen. I can hardly imagine a developer that would expect it to be enabled by default. |
|
@marcvangend the latest commit to master was Oct 7, 2014 ... I wouldn't hold your breath :) |
|
@bryan-ash Ouch, I knew Cycle2 isn't very actively maintained at the moment, but I didn't realize it has been that long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit just reverses the logic for enabling logging, as Issue #638 requests.