-
-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Add on_script_reloaded callback. #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shanecelis
wants to merge
4
commits into
makspll:main
Choose a base branch
from
shanecelis:reload-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−4
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,9 +2,10 @@ | |
|
||
On top of callbacks which are registered by your application, BMS provides a set of core callbacks which are always available. | ||
|
||
The two core callbacks are: | ||
The three core callbacks are: | ||
- `on_script_loaded` | ||
- `on_script_unloaded` | ||
- `on_script_reloaded` | ||
|
||
## `on_script_loaded` | ||
|
||
|
@@ -30,3 +31,24 @@ function on_script_unloaded() | |
print("Goodbye world") | ||
end | ||
``` | ||
|
||
## `on_script_reloaded` | ||
|
||
This will be called twice: right before and after a script is reloaded. | ||
|
||
The first parameter `save` informs you whether it is time to save a value or restore it. | ||
|
||
Before the reload, it is called with one argument: `true`. After the script is reloaded, it is called with two parameters: the first is `false` and the second is value returned from before. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as of now this seems to be misleading for non-shared contexts, in which case only the second half of the callback would happen |
||
|
||
```lua | ||
mode = 1 | ||
function on_script_reloaded(save, value) | ||
if save then | ||
print("Before I go, take this.") | ||
return mode | ||
else | ||
print("I'm back. Where was I?") | ||
mode = value | ||
end | ||
end | ||
``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None
for the missing argument