Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change python version from 2.7 to 3.6 #11

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

marongchao
Copy link

No description provided.

@marongchao
Copy link
Author

Merge - change python version from 2.7 to 3.6

@marongchao marongchao mentioned this pull request Aug 14, 2018
@kiorky
Copy link
Member

kiorky commented Aug 14, 2018

This is invalid, don't change, but add the trove classifier.

@marongchao
Copy link
Author

Hi Kiorky

Thanks for your quick response and comments. We need to change version to 3.6 because when i use conda with python3.6, the log shows that
"UnsatisfiableError: The following specifications were found to be in conflict:
easydict -> python 2.7*
python 3.6*"

Please find more details in this link
#8

Could you please elaborate a little bit more on steps I need to do for trove classifier?

It seems I need to add easydict to somehow in list for python 3.6 here https://pypi.org/search/?c=Programming+Language+%3A%3A+Python+%3A%3A+3.6?

Thanks
Rongchao

@marongchao
Copy link
Author

Hi Kiorky

I checked a little bit more it looks like classifiers(according to link below) is the classifiers in setup.py
which including the python version. Please kindly correct me if I missed something.
https://packaging.python.org/tutorials/packaging-projects/#classifiers

classifiers=['Topic :: Utilities',
'Natural Language :: English',
'Operating System :: OS Independent',
'Intended Audience :: Developers',
'Development Status :: 5 - Production/Stable',
'Programming Language :: Python :: 3.6'],

Thanks
Rongchao

@kiorky
Copy link
Member

kiorky commented Aug 14, 2018

It is a python list, you need to add the trove and not replace any old other one.

@marongchao
Copy link
Author

marongchao commented Aug 15, 2018

Hi Kiorky

Thanks for your suggestions. I've add back the old python version 2.5 in the trove classifiers. Please let me know if format is not correct because I am quite new for python package.

classifiers=['Topic :: Utilities', 
             'Natural Language :: English',
             'Operating System :: OS Independent',
             'Intended Audience :: Developers',
             'Development Status :: 5 - Production/Stable',
             'Programming Language :: Python :: 2.5',
             'Programming Language :: Python :: 3.6'],

Thanks
Rongchao

@kiorky
Copy link
Member

kiorky commented Aug 15, 2018

@marongchao It's fine now, please rebase/fixup your commits before merge !
Thx !
@leplatrem can you add kiorky on pypi or make the release yourself after merge ?

@marongchao
Copy link
Author

Hi Kiorky

I did rebase and there is no change in my repo. Please merge the change to main repo.

Thanks
Hongliu

@kiorky
Copy link
Member

kiorky commented Aug 16, 2018

You need to fixup (doc) your commits for us to merge a single and clean commit !

@marongchao
Copy link
Author

marongchao commented Aug 16, 2018

I squashed all my change in one commit. Hopefully it is good now.


git log

commit 70a6570 (HEAD -> master, origin/master, origin/HEAD)
Author: rongchao [email protected]
Date: Wed Aug 15 00:02:47 2018 +0800

Add python version 3.6 in classifiers

commit 2e0a757
Author: Mathieu Leplatre [email protected]
Date: Thu Apr 27 10:03:51 2017 +0200

Back to development: 1.8

@kiorky kiorky merged commit df79207 into makinacorpus:master Aug 16, 2018
@kiorky kiorky mentioned this pull request Aug 16, 2018
@NeighborhoodCoding
Copy link

CAN I install it? (I'm python 3.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants