-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change python version from 2.7 to 3.6 #11
Conversation
Merge - change python version from 2.7 to 3.6 |
This is invalid, don't change, but add the trove classifier. |
Hi Kiorky Thanks for your quick response and comments. We need to change version to 3.6 because when i use conda with python3.6, the log shows that Please find more details in this link Could you please elaborate a little bit more on steps I need to do for trove classifier? It seems I need to add easydict to somehow in list for python 3.6 here https://pypi.org/search/?c=Programming+Language+%3A%3A+Python+%3A%3A+3.6? Thanks |
Hi Kiorky I checked a little bit more it looks like classifiers(according to link below) is the classifiers in setup.py classifiers=['Topic :: Utilities', Thanks |
It is a python list, you need to add the trove and not replace any old other one. |
Hi Kiorky Thanks for your suggestions. I've add back the old python version 2.5 in the trove classifiers. Please let me know if format is not correct because I am quite new for python package.
Thanks |
@marongchao It's fine now, please rebase/fixup your commits before merge ! |
Hi Kiorky I did rebase and there is no change in my repo. Please merge the change to main repo. Thanks |
You need to fixup (doc) your commits for us to merge a single and clean commit ! |
I squashed all my change in one commit. Hopefully it is good now. git logcommit 70a6570 (HEAD -> master, origin/master, origin/HEAD)
commit 2e0a757
|
CAN I install it? (I'm python 3.6) |
No description provided.