Jimmy Lyons take-away challenge by jimmy-lyons · Pull Request #2233 · makersacademy/takeaway-challenge

jimmy-lyons · 2022-05-03T06:49:27Z

Jimmy Lyons

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

User story 1: "I would like to see a list of dishes with prices"
User story 2: "I would like to be able to select some number of several available dishes"
User story 3: "I would like to check that the total I have been given matches the sum of the various dishes in my order"
User story 4: "I would like to receive a text such as "Thank you! Your order was placed and will be delivered before 18:52" after I have ordered"

README checklist

Does your README contains instructions for

how to install,
how to run,
and how to test your code?

timbo-graham · 2022-05-03T09:11:26Z

@@ -0,0 +1,80 @@
+## Takeaway Weekdend Challenge


Good glaven this is a comprehensive and highly helpful README

timbo-graham · 2022-05-03T09:13:10Z

+  end
+
+  def see_restaurant_menu(restaurant)
+    @currently_viewed_menu = Menu.new(restaurant)


This is a nice bit of abstraction (think that's the word) - didn't occur to me at all

timbo-graham · 2022-05-03T09:14:18Z

+  end
+
+  def csv_to_hash
+    @file.readlines.each do |line|


Wish I could comment intelligently on how you've handled this with a .csv file, but it's way beyond my understanding

timbo-graham · 2022-05-03T09:17:27Z

+    @current_order.push({item => @menu.menu_hash[item]})
+  end
+
+  def remove(item)


This feels a little complicated for one method,, but I'm sure there are good reasons for that

Could you use encapsulation to move some of these long operations into a private method and make the main body of the code more readable?

timbo-graham · 2022-05-03T09:18:00Z

+    if current_order.empty?
+      @printed_order
+    else
+      format_order


timbo-graham · 2022-05-03T09:18:49Z

+  def order_total
+    @total = 0
+    calculate_total
+    return "£#{'%.2f' % @total}"


Oo, nice rounding

timbo-graham · 2022-05-03T09:21:33Z

+require 'twilio-ruby'
+
+class Text
+  def initialize(number, acc_sid, a_token)


Not sure I understand the thinking here, particularly with the method commented out in order.rb. Would be good to chat it through

SamButton12

Hi Jimmy, Lovely work on this challenge. I especially like that you've really gone beyond the user stories to add CSV files, use different types of restaurants and added a homepage.

SamButton12 · 2022-05-03T09:33:22Z

+      expect(subject.display_restaurants).to be_an_instance_of(String)
+    end
+
+    # it 'should list restaurants with corresponding csv files' do


I think that best practice is to delete redundant code and comments before pull requesting. (nit-picking)

SamButton12 · 2022-05-03T09:36:14Z

+      expect(order.current_order.length).to eq 1
+    end
+
+    it 'should only add items from the initialised menu' do


You could make this slightly more readable. You already have the #add describe block, so probably dont need the 'add' in the it block (nit-picking)

SamButton12 · 2022-05-03T09:38:30Z

+  end
+
+  def see_restaurant_menu(restaurant)
+    @currently_viewed_menu = Menu.new(restaurant)


Would initializing a new menu and order help here?

SamButton12 · 2022-05-03T09:40:06Z

+    @current_order.push({item => @menu.menu_hash[item]})
+  end
+
+  def remove(item)


Could you use encapsulation to move some of these long operations into a private method and make the main body of the code more readable?

eoinmakers

Good implementation of the Takeaway challenge, well done. You've clearly demonstrated the objectives of the week.

There's a good range of unit tests here, but in some cases all you need to do is verify that other methods have been called. https://stackoverflow.com/questions/21262309/rspec-how-to-test-if-a-method-was-called For example, where a method is responsible for calling a private method, or a method of another class.

eoinmakers · 2022-05-06T16:31:54Z

+    @order = nil
+  end
+
+  def display_restaurants


This feels like an addition to the project specs, which you should be careful about - trying to adhere as closely to the spec as possible is always a priority for projects & tech tests.

eoinmakers · 2022-05-06T16:32:35Z

+# Can't figure out how to put csv files in a separate folder.
+# It always seems to return an error.
+
+class Menu


In this project, something as simple as a Hash or array of Dish objects is fine to represent the menu.

eoinmakers · 2022-05-06T16:34:22Z

+    array_item = {item => @menu.menu_hash[item]}
+    fail "Input error: Item not in current order." unless @current_order.include? array_item
+    i = current_order.find_index(array_item)
+    @current_order.delete_at(i)


Deleting an item from the order is also an additional feature! It's definitely functional, but adds unnecessary complexity to your development and end result.

eoinmakers · 2022-05-06T16:34:45Z

+  # def confirm_order(number, acc_sid, a_token)
+  #   # method required to send order to restaurant
+  #   sms = Text.new(number, acc_sid, a_token)
+  # end


We try to remove commented out code / test snippets before opening PRs for tidiness.

jimmy-lyons added 14 commits May 1, 2022 09:36

local repo initialised and menu.rb and menu_spec.rb created

b7a9439

added csv folders and file for menus

73539aa

able to load csv menus and convert to hash

d28ddec

added vietnamese menu

1b87c88

added fucntion to print selected menu

32d9d13

homepage can create and read instances of menu

cf906b5

added test to check that show_current_order returns a foramtted list

52c322a

new instances of order now initialise to a specific menu

e325130

remove item from current order feature added

50c72ea

resolved order total functionality

29fe87d

created text class which sends confirmation messages

62fcc73

env files to be ignored

9649b3b

removed env file

7467a5e

Updated README_JL with project info

6106507

timbo-graham reviewed May 3, 2022

View reviewed changes

SamButton12 reviewed May 3, 2022

View reviewed changes

eoinmakers reviewed May 6, 2022

View reviewed changes

Uh oh!

Conversation

jimmy-lyons commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jimmy Lyons

User stories

README checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SamButton12 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eoinmakers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jimmy-lyons commented May 3, 2022 •

edited

Loading